Provide an option to inverse photo order

Bug #679726 reported by languitar
This bug report is a duplicate of:  Bug #679933: Additional Buttons in tab "Images". Edit Remove
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hugin
Triaged
Wishlist
Unassigned

Bug Description

Please provide an option to simply inverse the photo ordering. I sometimes take my photos from right to left and then I have to change the ordering of the photos one by one. Otherwise assigning key points is really hard of left is right and right is left and so on. ;)

Revision history for this message
Bruno Postle (brunopostle) wrote :

This would be useful, switching to feature requests tracker.

Revision history for this message
Yuv (yuv) wrote :

useful indeed, and I had an itch tonight...

Revision history for this message
Yuv (yuv) wrote :

The file invert_order.patch was added: implemented feature patch

Revision history for this message
Yuv (yuv) wrote :

moving to patches. need to be tested, and checked if compatible with new layout mode

Revision history for this message
Bruno Postle (brunopostle) wrote :

I haven't tested it yet, but some comments from looking at the patch:

This needs to be on the Images tab rather then the Control Points tab, we already have 'Move up' and Move down' buttons on the Images tab and this belongs next to them.

There should definitely not be any operators on the Control Points tab that modify photos other than the displayed pair.

Operators on the Images tab should operate on just the selected images rather than the entire image set.

Other than that, this will be very useful because the order of images determines the enblend seam blending order so reversing the sequence will have a real effect on the rendered output.

Revision history for this message
Yuv (yuv) wrote :

Hi Bruno,

There are two separate issues:
1. inverting the order of the whole set of images for the purpose of manually editing CPs (which is how I understand Johannes' request; and which is also what I find useful to me).
2. manipulating the order of the images for the purpose of blending.

While I may agree with you that for purpose (2) the Images tab may be a better place than the CP tab; and that operators there should operate on just the selected images rather than the entire image set; this is a completely different scope from what I find useful for myself and implemented.

What I have implemented applies *only* to the complete set of images and is intended to be used only at the early stage of the process. It's on the CP tab that I realize that I have shot right to left instead of left to right and need inverting the complete set.

For the purpose of blending, move up / move down are enough at this point. My patch does not help, and the approach would be the wrong one anyway. The right approach to blending order IMO would be drag and drop. I'm still not familiar enough with wxWidgets to implement that.

Revision history for this message
Bruno Postle (brunopostle) wrote :

Yuv, I appreciate that you don't want/need to make the tool work on subsets of photos, but the Control Point tab is absolutely the wrong place to put a button that modifies every image in the project. It would be acceptable in the Preview window or the Images tab, but the Control Points tab is for working with pairs of images.

Revision history for this message
tmodes (tmodes) wrote :

Yuv,
your patchs compiles and first test show, that it works as intended.
I agree to Bruno, the button belongs to the Image tab.

But I think the function is too special. We have a lot of buttons on the image tab yet. So I would propose a more general function: sort the images by different criterias like ptosort. So the images can be sorted by filename, image position or exposure value (maybe customizable in a new dialog). All ascending and descending. With this we get the same functionality and have a more generally usabable function, which works also for other cases than a single row panorama from right to left.

PS: When you create a new panocommand, return a better description in panocommand::getName, e.g. return "invert order".

Revision history for this message
Yuv (yuv) wrote :

Thomas, Bruno, thanks for the feedback.

re panocommand, I'll do that in the future, thanks Thomas.

I now understand and agree with you that this button as it stands now belongs to the images tab. And it is "manipulating the order of the images for the purpose of blending.", like the many other functions / sorting orders that Thomas suggest.

What I am trying to solve here (and I have used the wrong means) is a user interface issue of the CP tab. Now I know that I want to invert the positions of the two images on the CP tab; and not invert the sort order of the photos. I am no wxWidgets expert and the few things I have tried so far to re-assign the position of the widgets on the screen don't work. What I want to fix is CP editing for a sequence that is from right to left (currently the CP tab is oriented left to right only). The rest, (sorting order), belongs on the Images tab, and can be sorted out later.

Revision history for this message
Yuv (yuv) wrote :

stupid me! it is so simple. just select the left and right (or right and left) images in the appropriate pane of the CP tab. then moving forward and backward works even for "inverted" shots. sorry, my mistake not to see the obvious.

to manipulate the sort order of the images for blending purposes, the attached patch is too specific. but now that I've worked my way inside the structure, I may as well continue and implement the ideas contributed by Bruno and Thomas.

I've looked at the images tab. I'd like to be able to drag and drop entries in the table. I'll see if I can do this. However it is useless if I don't have a visual feedback, i.e. see the images as thumbnails rather than as a table list. but then I don't like tables of images because they waste a lot of space; and much of the tabulated information is quite irrelevant when choosing the blending order.

The more I think of this, the more it goes into "layout"....

Revision history for this message
Bruno Postle (brunopostle) wrote :

Hi Yuv, the Control Points tab could still use a button to swap the display of the current pair of images. There is space for this in between the forward/backward pair of buttons - This would just swap the pull-down menu entries rather than rearrange the project order.

The Images tab has long needed the ability to drag images up and down the list, but there are lots of things that need fixing - e.g. the selection should be shared between the Images, Camera and Lens and Crop tab.

tmodes (tmodes)
Changed in hugin:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: hugin usability
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.