pyexiv2-0.3.0 docs fail to build with sphinx-1.0.5

Bug #696240 reported by Chris Mayo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pyexiv2
Fix Released
Low
Olivier Tilloy

Bug Description

Running Sphinx v1.0.5
loading pickled environment... not yet created
scons: done reading SConscript files.
scons: Building targets ...
build_doc(["doc/_build/api.html", "doc/_build/index.html", "doc/_build/developers.html", "doc/_build/release_procedure.html", "doc/_build/tutorial.html"], ["doc/api.rst", "doc/index.rst", "doc/developers.rst", "doc/release_procedure.rst", "doc/tutorial.rst"])
scons: *** [doc/_build/api.html] TypeError : build() got an unexpected keyword argument 'all_files'
Traceback (most recent call last):
  File "/usr/lib/scons-2.0.1/SCons/Action.py", line 1046, in execute
    result = self.execfunction(target=target, source=rsources, env=env)
  File "/var/tmp/portage/dev-python/pyexiv2-0.3.0/work/pyexiv2-0.3.0/doc/SConscript", line 23, in build_doc
    sphinx.build(all_files=False, filenames=[])
TypeError: build() got an unexpected keyword argument 'all_files'
scons: building terminated because of errors.

sphinx-1.0.5 has:
Sphinx.build(self, force_all=False, filenames=None)

Just removing the "all_files=False" fixes it for me. Patch attached.

Related branches

Revision history for this message
Chris Mayo (chris-mayo) wrote :
Revision history for this message
Olivier Tilloy (osomon) wrote :

The "all_files" parameter (as found in sphinx 0.6.6) was renamed to "force_all" in sphinx 1.0.

Removing the parameter works there because it has a default value of False, but it wouldn’t work for earlier versions that don’t define a default value. However, passing the value without explicitly naming the parameter should work, as the order of the parameters and their meanings remained unchanged.

Changed in pyexiv2:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Olivier Tilloy (osomon) wrote :

Fixed with revision 350 in the trunk.

Changed in pyexiv2:
assignee: nobody → Olivier Tilloy (osomon)
status: Confirmed → Fix Committed
Olivier Tilloy (osomon)
Changed in pyexiv2:
milestone: none → 0.3.1
Olivier Tilloy (osomon)
Changed in pyexiv2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.