Odoo Server (MOVED TO GITHUB)

Miscalculation of parent_store data when moving multiple records under same parent

Bug #708603 reported by Amit Parik
28
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Fix Released
High
OpenERP's Framework R&D
Odoo Server (MOVED TO GITHUB) 6.0.2
5.0
Fix Released
High
Jay Vora (Serpent Consulting Services)
Odoo Server (MOVED TO GITHUB) 5.0.16

Bug Description

When i duplicate a account to ctrl+shift+d i found this traceback on server side.

[2011-01-27 17:40:25,970][db_trunk_inv] ERROR:web-services:Uncaught exception
Traceback (most recent call last):
  File "/home/tiny/workspace/openobject-server/bin/osv/osv.py", line 122, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/home/tiny/workspace/openobject-server/bin/osv/osv.py", line 176, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/home/tiny/workspace/openobject-server/bin/osv/osv.py", line 167, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/home/tiny/workspace/openobject-addons/account/account.py", line 495, in copy
    child_ids = self.copy(cr, uid, child.id, default, context=context, done_list=done_list, local=True)
  File "/home/tiny/workspace/openobject-addons/account/account.py", line 495, in copy
    child_ids = self.copy(cr, uid, child.id, default, context=context, done_list=done_list, local=True)
  File "/home/tiny/workspace/openobject-addons/account/account.py", line 501, in copy
    return super(account_account, self).copy(cr, uid, id, default, context=context)
  File "/home/tiny/workspace/openobject-server/bin/osv/orm.py", line 4145, in copy
    data = self.copy_data(cr, uid, id, default, context)
  File "/home/tiny/workspace/openobject-server/bin/osv/orm.py", line 4031, in copy_data
    data = self.read(cr, uid, [id,], context=context_wo_lang)
  File "/home/tiny/workspace/openobject-server/bin/osv/orm.py", line 2921, in read
    result = self._read_flat(cr, user, select, fields, context, load)
  File "/home/tiny/workspace/openobject-server/bin/osv/orm.py", line 3032, in _read_flat
    res2 = self._columns[val[0]].get(cr, self, ids, val, user, context=context, values=res)
  File "/home/tiny/workspace/openobject-server/bin/osv/fields.py", line 793, in get
    res = self._fnct(obj, cr, user, ids, name, self._arg, context)
  File "/home/tiny/workspace/openobject-addons/account/account.py", line 305, in __compute
    sums[current.id][fn] += sums[child.id][fn]

It took more number of digits then actual in account code.

Thanks

Related branches

lp://qastaging/~openerp-commiter/openobject-addons/trunk-dev-addons3-mtr1
OpenERP R&D Team: Pending requested
Diff: 667 lines (+70/-70)
41 files modified
account_voucher/account_voucher.py (+1/-1)
account_voucher/i18n/account_voucher.pot (+1/-1)
account_voucher/i18n/ar.po (+1/-1)
account_voucher/i18n/bg.po (+1/-1)
account_voucher/i18n/bs.po (+1/-1)
account_voucher/i18n/ca.po (+3/-3)
account_voucher/i18n/cs.po (+1/-1)
account_voucher/i18n/de.po (+2/-2)
account_voucher/i18n/el.po (+3/-3)
account_voucher/i18n/es.po (+4/-4)
account_voucher/i18n/es_AR.po (+1/-1)
account_voucher/i18n/es_EC.po (+4/-4)
account_voucher/i18n/et.po (+1/-1)
account_voucher/i18n/fr.po (+2/-2)
account_voucher/i18n/hi.po (+1/-1)
account_voucher/i18n/hr.po (+1/-1)
account_voucher/i18n/hu.po (+2/-2)
account_voucher/i18n/id.po (+1/-1)
account_voucher/i18n/it.po (+3/-3)
account_voucher/i18n/ko.po (+1/-1)
account_voucher/i18n/lt.po (+3/-3)
account_voucher/i18n/mn.po (+1/-1)
account_voucher/i18n/nl.po (+1/-1)
account_voucher/i18n/nl_BE.po (+1/-1)
account_voucher/i18n/oc.po (+1/-1)
account_voucher/i18n/pl.po (+2/-2)
account_voucher/i18n/pt.po (+3/-3)
account_voucher/i18n/pt_BR.po (+2/-2)
account_voucher/i18n/ro.po (+3/-3)
account_voucher/i18n/ru.po (+1/-1)
account_voucher/i18n/sl.po (+1/-1)
account_voucher/i18n/sq.po (+1/-1)
account_voucher/i18n/sr.po (+2/-2)
account_voucher/i18n/sr@latin.po (+2/-2)
account_voucher/i18n/sv.po (+1/-1)
account_voucher/i18n/tlh.po (+1/-1)
account_voucher/i18n/tr.po (+3/-3)
account_voucher/i18n/uk.po (+1/-1)
account_voucher/i18n/vi.po (+1/-1)
account_voucher/i18n/zh_CN.po (+3/-3)
account_voucher/i18n/zh_TW.po (+1/-1)
lp://qastaging/openobject-addons
lp://qastaging/openobject-server/6.0
OpenERP Core Team: Pending requested
Diff: 525549 lines (+338109/-2276) (has conflicts)
150 files modified
debian/changelog (+9/-0)
debian/po/ar.po (+41/-0)
debian/po/bg.po.OTHER (+42/-0)
debian/po/ca.po.OTHER (+43/-0)
debian/po/cs.po.OTHER (+41/-0)
debian/po/da.po (+42/-0)
debian/po/de.po.OTHER (+42/-0)
debian/po/el.po.OTHER (+42/-0)
debian/po/en_GB.po.OTHER (+42/-0)
debian/po/es.po.OTHER (+43/-0)
debian/po/es_CL.po.OTHER (+42/-0)
debian/po/es_EC.po.OTHER (+42/-0)
debian/po/fa.po.OTHER (+41/-0)
debian/po/fi.po.OTHER (+41/-0)
debian/po/fr.po.OTHER (+41/-0)
debian/po/gl.po.OTHER (+41/-0)
debian/po/he.po.OTHER (+39/-0)
debian/po/hr.po.OTHER (+42/-0)
debian/po/hu.po.OTHER (+42/-0)
debian/po/is.po (+41/-0)
debian/po/it.po.OTHER (+41/-0)
debian/po/ja.po.OTHER (+39/-0)
debian/po/ko.po.OTHER (+40/-0)
debian/po/lv.po.OTHER (+39/-0)
debian/po/mk.po (+42/-0)
debian/po/mn.po.OTHER (+41/-0)
debian/po/nb.po.OTHER (+41/-0)
debian/po/nl.po.OTHER (+42/-0)
debian/po/pl.po.OTHER (+41/-0)
debian/po/pt.po.OTHER (+41/-0)
debian/po/pt_BR.po.OTHER (+42/-0)
debian/po/ro.po.OTHER (+41/-0)
debian/po/ru.po.OTHER (+42/-0)
debian/po/sk.po.OTHER (+42/-0)
debian/po/sl.po (+41/-0)
debian/po/sq.po.OTHER (+42/-0)
debian/po/sr.po.OTHER (+41/-0)
debian/po/sv.po.OTHER (+41/-0)
debian/po/tr.po.OTHER (+41/-0)
debian/po/uk.po.OTHER (+42/-0)
debian/po/vi.po.OTHER (+42/-0)
debian/po/zh_CN.po.OTHER (+38/-0)
debian/po/zh_TW.po.OTHER (+40/-0)
history/Changelog (+619/-0)
openerp/addons/base/base_data.xml (+626/-0)
openerp/addons/base/i18n/ab.po (+9239/-0)
openerp/addons/base/i18n/af.po (+1614/-21)
openerp/addons/base/i18n/am.po (+1705/-20)
openerp/addons/base/i18n/ar.po (+5333/-88)
openerp/addons/base/i18n/bg.po (+1583/-18)
openerp/addons/base/i18n/bn.po (+9239/-0)
openerp/addons/base/i18n/bs.po (+4580/-91)
openerp/addons/base/i18n/ca.po (+1635/-18)
openerp/addons/base/i18n/cs.po (+3166/-40)
openerp/addons/base/i18n/da.po (+3006/-47)
openerp/addons/base/i18n/de.po (+3215/-49)
openerp/addons/base/i18n/el.po (+1565/-18)
openerp/addons/base/i18n/en_GB.po (+2725/-30)
openerp/addons/base/i18n/es.po (+1776/-19)
openerp/addons/base/i18n/es_AR.po (+6236/-119)
openerp/addons/base/i18n/es_BO.po (+9239/-0)
openerp/addons/base/i18n/es_CL.po (+2062/-27)
openerp/addons/base/i18n/es_CR.po (+9597/-0)
openerp/addons/base/i18n/es_DO.po (+9487/-0)
openerp/addons/base/i18n/es_EC.po (+1678/-18)
openerp/addons/base/i18n/es_HN.po (+9295/-0)
openerp/addons/base/i18n/es_MX.po (+9246/-0)
openerp/addons/base/i18n/es_PA.po (+9295/-0)
openerp/addons/base/i18n/es_PE.po (+9239/-0)
openerp/addons/base/i18n/es_VE.po (+9251/-0)
openerp/addons/base/i18n/et.po (+2156/-29)
openerp/addons/base/i18n/eu.po (+1550/-18)
openerp/addons/base/i18n/fa.po (+3255/-65)
openerp/addons/base/i18n/fa_AF.po (+1550/-18)
openerp/addons/base/i18n/fi.po (+2186/-28)
openerp/addons/base/i18n/fr.po (+2078/-26)
openerp/addons/base/i18n/fr_CA.po (+9248/-0)
openerp/addons/base/i18n/gl.po (+2583/-37)
openerp/addons/base/i18n/gu.po (+9292/-0)
openerp/addons/base/i18n/he.po (+2211/-32)
openerp/addons/base/i18n/hi.po (+9239/-0)
openerp/addons/base/i18n/hr.po (+1946/-23)
openerp/addons/base/i18n/hu.po (+4826/-40)
openerp/addons/base/i18n/hy.po (+2685/-33)
openerp/addons/base/i18n/id.po (+1624/-20)
openerp/addons/base/i18n/is.po (+2573/-28)
openerp/addons/base/i18n/it.po (+1692/-22)
openerp/addons/base/i18n/ja.po (+5598/-101)
openerp/addons/base/i18n/ka.po (+9505/-0)
openerp/addons/base/i18n/kab.po (+9300/-0)
openerp/addons/base/i18n/kk.po (+9239/-0)
openerp/addons/base/i18n/ko.po (+5358/-98)
openerp/addons/base/i18n/lt.po (+2721/-47)
openerp/addons/base/i18n/lv.po (+2192/-30)
openerp/addons/base/i18n/mk.po (+4789/-83)
openerp/addons/base/i18n/mn.po (+2681/-38)
openerp/addons/base/i18n/nb.po (+1869/-9)
openerp/addons/base/i18n/nl.po (+2324/-30)
openerp/addons/base/i18n/nl_BE.po (+1554/-18)
openerp/addons/base/i18n/pl.po (+3247/-37)
openerp/addons/base/i18n/pt.po (+4373/-74)
openerp/addons/base/i18n/pt_BR.po (+2728/-33)
openerp/addons/base/i18n/ro.po (+5276/-71)
openerp/addons/base/i18n/ru.po (+1699/-18)
openerp/addons/base/i18n/sk.po (+1599/-18)
openerp/addons/base/i18n/sl.po (+4980/-100)
openerp/addons/base/i18n/sq.po (+1550/-18)
openerp/addons/base/i18n/sr.po (+1570/-18)
openerp/addons/base/i18n/sr@latin.po (+5821/-114)
openerp/addons/base/i18n/sv.po (+1908/-25)
openerp/addons/base/i18n/ta.po (+9295/-0)
openerp/addons/base/i18n/th.po (+3948/-67)
openerp/addons/base/i18n/tlh.po (+2209/-19)
openerp/addons/base/i18n/tr.po (+2519/-35)
openerp/addons/base/i18n/uk.po (+1630/-21)
openerp/addons/base/i18n/ur.po.OTHER (+9239/-0)
openerp/addons/base/i18n/vi.po (+2458/-43)
openerp/addons/base/i18n/zh_CN.po (+1903/-22)
openerp/addons/base/i18n/zh_HK.po (+9239/-0)
openerp/addons/base/i18n/zh_TW.po (+2239/-25)
openerp/addons/base/ir/ir_actions.py (+5/-0)
openerp/addons/base/ir/ir_filters.py (+7/-0)
openerp/addons/base/ir/ir_model.py (+17/-0)
openerp/addons/base/ir/ir_rule.py (+18/-0)
openerp/addons/base/ir/ir_values.py (+136/-0)
openerp/addons/base/publisher_warranty/publisher_warranty.py.OTHER (+362/-0)
openerp/addons/base/report/corporate_sxw_header.xml (+20/-2)
openerp/addons/base/res/res_config.py (+35/-0)
openerp/addons/base/res/res_currency.py (+32/-1)
openerp/addons/base/res/res_log.py.OTHER (+96/-0)
openerp/addons/base/res/res_partner.py (+217/-0)
openerp/addons/base/res/res_partner_report_address.xml (+14/-0)
openerp/addons/base/res/res_partner_view.xml (+5/-0)
openerp/addons/base/res/res_users.py (+56/-1)
openerp/addons/base/tests/test_osv_expression.yml (+17/-0)
openerp/modules/loading.py (+13/-0)
openerp/osv/expression.py (+121/-0)
openerp/osv/fields.py (+69/-0)
openerp/osv/orm.py (+797/-16)
openerp/osv/osv.py (+394/-0)
openerp/release.py (+6/-0)
openerp/report/interface.py (+8/-0)
openerp/report/printscreen/ps_list.py (+11/-0)
openerp/report/render/rml2pdf/trml2pdf.py (+20/-0)
openerp/report/report_sxw.py (+10/-0)
openerp/sql_db.py (+17/-0)
openerp/tools/convert.py (+18/-0)
openerp/tools/misc.py (+251/-1)
openerp/tools/safe_eval.py (+18/-1)
openerp/tools/translate.py (+73/-0)
lp://qastaging/openobject-server/5.0
lp://qastaging/openobject-server
Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: New → Confirmed
Meera Trambadia (OpenERP) (mtr-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello Amit,

Its fixed in https://code.launchpad.net/~openerp-commiter/openobject-addons/trunk-dev-addons3-mtr1 branch.
Revision ID: mtr@mtr-20110128114450-998ho3olsdfno7yw
Revision no: 4715

Thanks
mtr

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

@Meera: I have checked your commit, you can try like " if sums.get(child.id, False) ".

Changed in openobject-addons:
status: Fix Committed → Confirmed
Meera Trambadia (OpenERP) (mtr-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello Mustufa Rangwala,

I have improved my changes as per your suggestion i.e.sums.get(child.id, False).

Its fixed in https://code.launchpad.net/~openerp-commiter/openobject-addons/trunk-dev-addons3-mtr1 branch.
Revision ID: mtr@mtr-20110131063645-pjwyyj3uv1jp40i1
Revision no: 4718

Thanks
mtr

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello,

I have improved my code committed in the revision no 4718 (comment #3)
So the new Revision no: 4721
Revision ID: mtr@mtr-20110131080207-hmsbxkmonkvdh3to

Thanks
mtr

Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
Olivier Dony (Odoo) (odo-openerp)
Changed in openobject-addons:
milestone: none → 6.0.2
Jay Vora (Serpent Consulting Services) (jayvora)
affects: openobject-addons → openobject-server
Changed in openobject-server:
assignee: OpenERP R&D Addons Team 3 (openerp-dev-addons3) → OpenERP's Framework R&D (openerp-dev-framework)
importance: Low → Medium
milestone: 6.0.2 → none
status: Fix Released → Confirmed
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Thanks to Jay's careful review, we noticed that the fix suggested in previous comments and already merged, is on fact only hiding an underlying bug in the framework, which causes an invalid update of the parent_left/right column values after the duplication.
This can have much dire consequences, so it is better to prevent duplication until the server issue is fixed.
As a result, the patch in addons-trunk was reverted by revision 4404 <email address hidden>.

Olivier Dony (Odoo) (odo-openerp)
summary: - Traceback occurs at the time of "Account" duplication.
+ Miscalculation of parent_store data when moving multiple records under
+ same parent
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

The fix has landed in 6.0 and was ported to trunk as well:
- 6.0: rev 3334 <email address hidden>
- trunk: rev 3342 <email address hidden>

I'm adding a bug task for 5.0 as well, in order for maintenance team to evaluate whether this should be backported to 5.0. I think it's very low-risk and quite important... and that code has not changed much since 5.0...

Changed in openobject-server:
importance: Medium → High
milestone: none → 6.0.2
status: Confirmed → Fix Released
tags: added: maintenance
Anup(SerpentCS) (anup-serpent)
tags: added: 5.0 6.0
Revision history for this message
Anup(SerpentCS) (anup-serpent) wrote :

Hello Guys,

      It has been fixed in version 5.0 by revision 2171 <email address hidden>

@Olivier
    Thank you very much for pointing towards such a crucial issue in stable. Excellent fix as always.

Thanks.

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

On a related note, YAML tests were added in trunk to validate the behavior of the parent_store update system, in the different cases: see rev 3343 <email address hidden>.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.