Tests of the 1.3.0

Bug #709934 reported by Olivier Girard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Medium
Unassigned

Bug Description

I have began to release some tests and I have found two bugs with the play head.

System Lucid Lynx 64 bits, LinuxMintDebianEdition 64 bits

The first is when you create a mark anywhere, if it is a new or an old project, if you move with the mouse or if you stop a preview anywhere. Impossible to move the play head either with the mouse either on the arrow previous mark following mark.
The only mean to move it is to use the button play on the preview and , only after that you can create some others which are okay those ones.

The second is when you (after to have done the first) want to go to the begin of the project. Impossible but you can go to the end. And after it is impossible to go with the arrow for the begin of the project. The trick is to move back, stop and use the arrow to go to the beginning. And here the play head go to the beginning but some fews seconds she is coming back at the last
position where she was when she moves back.

I have some problems with the shortcuts on the LMDE and I am not really sure that's the fault of OS (F1, F2 and all who is in the menu Help) All the others keybords works. I will said that more a problem with my keyboard (this one is of bad quality) and I have none problem on the Lucid. I must do more tests for that.

For the moment that's all. :)

Revision history for this message
Olivier Girard (eolinwen) wrote :

I found another bug with the files audio, but only on a format.
The project is an old project but it is the same when i import several audio files of different type.
I was a audio file in Flac who is not in the tab audio but in the tab Image.
I have done an import of some audio files in the following formats : wav, mp3, ogg and flac.
And if the others types (mp3, ogg and wav) are at the good place, once more the flac file is in the Image tab with the other.

Revision history for this message
Olivier Girard (eolinwen) wrote :

I have found (rather confirm) the bug with the direct import of a Image sequence. I have found a work around importing before the first image like another file. Openshot recognizes it and ask me if i want to import this file like a Image sequence and i am agree. After, I done my Image Sequence Import normally (i.e. I choose only the folder) and my sequence is imported.

I have played a little with the mapworld trying to change the map. I have move/put the two maps (in the formats .xcf and .svg) in the folder hidden .openshot (and it will be more easy to create a folder in this one ? ). After I have set up the good path in the right place and i have a gray map (see the screenshot).

I have played with the frame animation and I have specified my path for the images (i.e. /home/me/Images/Jardin/myphotos.JPG or jpg it is the same) I obtain a gray square instead of the picture See the screenshot for the parameters and the screencast for the result)

I put a screencast for the play head who is not only difficult to move but neither she comes back at his initial position.

Revision history for this message
Olivier Girard (eolinwen) wrote :
Revision history for this message
Olivier Girard (eolinwen) wrote :
Revision history for this message
Olivier Girard (eolinwen) wrote :
Revision history for this message
Andy Finch (fincha) wrote :

#1, the FLAC files problem is already logged as a bug.

I can't reproduce the other problems you are having with the markers/moving the play head (on 9.10).

Revision history for this message
Jonathan Thomas (jonoomph) wrote : Re: [Openshot.developers] [Bug 709934] [NEW] Tests of the 1.3.0
Download full text (4.2 KiB)

Hi Olivier! Thanks for the testing effort! The "Previous Marker" and "Next
Marker" toolbar buttons were moved to the bottom toolbar (i.e. above the
timeline). So, all 3 buttons related to "markers" are all together now, and
not to be confused with the default media buttons (i.e. rewind, fast
forward, play, pause, etc...). I am able to add markers, seek to them, and
remove them without any issues. So, I'm not sure if I understand how to
reproduce this. Also, I watched your video screencast, but the framerate
was very low, and I'm not sure what was not working.

The keyboard shortcuts was messed up for "Help". It is now "F1" and the
menu option is called "Contents".

Flac files have trouble with FFmepg determine their length, which is causing
MLT to default their length to 15000 frames long, which then causes OpenShot
to think it's an image.

Thanks!
-Jonathan

On Sat, Jan 29, 2011 at 4:19 PM, cenwen <email address hidden> wrote:

> Public bug reported:
>
> I have began to release some tests and I have found two bugs with the
> play head.
>
> System Lucid Lynx 64 bits, LinuxMintDebianEdition 64 bits
>
> The first is when you create a mark anywhere, if it is a new or an old
> project, if you move with the mouse or if you stop a preview anywhere.
> Impossible to move the play head either with the mouse either on the arrow
> previous mark following mark.
> The only mean to move it is to use the button play on the preview and ,
> only after that you can create some others which are okay those ones.
>
> The second is when you (after to have done the first) want to go to the
> begin of the project. Impossible but you can go to the end. And after it is
> impossible to go with the arrow for the begin of the project. The trick is
> to move back, stop and use the arrow to go to the beginning. And here the
> play head go to the beginning but some fews seconds she is coming back at
> the last
> position where she was when she moves back.
>
> I have some problems with the shortcuts on the LMDE and I am not really
> sure that's the fault of OS (F1, F2 and all who is in the menu Help) All
> the others keybords works. I will said that more a problem with my
> keyboard (this one is of bad quality) and I have none problem on the
> Lucid. I must do more tests for that.
>
> For the moment that's all. :)
>
> ** Affects: openshot
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to OpenShot Video Editor.
> https://bugs.launchpad.net/bugs/709934
>
> Title:
> Tests of the 1.3.0
>
> Status in OpenShot Video Editor:
> New
>
> Bug description:
> I have began to release some tests and I have found two bugs with the
> play head.
>
> System Lucid Lynx 64 bits, LinuxMintDebianEdition 64 bits
>
> The first is when you create a mark anywhere, if it is a new or an old
> project, if you move with the mouse or if you stop a preview anywhere.
> Impossible to move the play head either with the mouse either on the arrow
> previous mark following mark.
> The only mean to move it is to use the button play on the preview and ,
> only after that you can create ...

Read more...

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

I do not believe Blender can use SVG images, which is why the map does not show the texture. Also, a little tip for you. If any of the Blender animations give you trouble, OpenShot outputs the actual command that is shelled out to the terminal. If you copy & paste that command in a terminal window, it should run Blender and output any errors.

I will investigate the picture boxes, and see why they are breaking.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Olivier, I have not been able to reproduce any issues moving the playhead. Are there any errors in the terminal? Also, is there some action which triggers the problem, or does the problem always happen, no matter what you are doing?

Revision history for this message
Joop Mevissen (jm) wrote :

I have the same issues with the markers: if you add a marker you cannot move the playhead by dragging it. You have to click somewhere on the ruler or click the play button, to be able to grab it. It seems as if the marker is in front of the playhead, blocking it for grabbing. This is especially the case with themes where the marker is the same size as the playhead (ie the fresh theme).

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Ahhh, I now understand the issue with markers. This is now fixed and committed to the trunk. When adding a playhead, it now moves the playhead above the new marker.

Also, I added a new double click event to markers, which will seek the playhead to the position of the marker.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

I have completely re-written the Blender animation with the 4 pictures. It now lets the user select an image or video clip from the "Project Files". Then it sets the geometry of the "plane"s in blender to equal the aspect raito of the image or video (so it does not stretch the image).

This required some changes to the thumbnail.py file, which now correct gets the size of images (height / width). On older project files, this will not scale the images correctly, as the images will have the incorrect size in OpenShot. But, for newly created OpenShot projects, it should work correctly.

It's a pretty neat effect, having videos playing in the 4 boxes. =) Although, I wouldn't get too excited, since many useful options are still missing, such as the starting frame, duration, sound, etc... But it's still kinda cool.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

I found some issues with the "Import Image Sequence" screen, and replace the validation code with a regular expression. This is now much more accurate when verifying an image sequence file pattern will actually match a file.

Changed in openshot:
milestone: none → 1.3.0
Revision history for this message
Olivier Girard (eolinwen) wrote :

I have began to re-done some tests.

Perfect for the Blender animation with 4 pictures and the video. I was thinking to find a bug and look to create a patch with the combobox who were not active and, just before to look that I have noted that was normal. None file was selected !!!! I was just open a blank project and the blank window. =) That 's great now in the combobox, we look the files of the project.

No problems now with the markers and the play-head.

I have found another one with the ..............markers and the buttuns Next and Previous. You have a look with the previous video (okay I know we looks not well) but I will try to explain. Be careful :) ^ ^
When I use the preview or dragging it on a point in the timeline, I wish to go to the next marker. No problem with but when I want to go to the begin or the end with their button, they go (for sample at the end) to the desire position but she comes back at the marker. She does'nt stay at the end. I try again and again, the play head go to end and comes back again and again.

Revision history for this message
Olivier Girard (eolinwen) wrote :

I have tested the folder with the current folder, yeah Great.
It is damage that we can not drag and drop the clip in the folder and we must use the right clic for doing this operation.

I have an Issue not linked at this directly but when you create a folder the action validate is not possible with the keyboard Enter (but possible with the action (clicking on the button)). I put some screenshots for showing how it is now.

Revision history for this message
Olivier Girard (eolinwen) wrote :
Revision history for this message
Olivier Girard (eolinwen) wrote :

Always present the bug in MLT with the mpg1 in the preview. Read the file, stop it, move the timeline or use the marker and re-launch the preview and you have a blank preview for all the rest of the clip.

Revision history for this message
Olivier Girard (eolinwen) wrote :

In the sequence of Image, it is always the same thing. Same process for import a folder and It is impossible to import a folder without the workaround that I have found. And even I have another one. I have a folder with two different name : 5 called Test01 at 05.png and 24 called Test_25 (to Test_6 at Test_29). When I import a picture of any type I should have either the 5 for the first type either the 24 for the second. Each time, I import only the first frame. He doesn't want the other. It seems that like there is two denominations in the same folder that he doesn't know which one import.

Revision history for this message
Olivier Girard (eolinwen) wrote :

Effectively, for the Blender Animation World Map, the user must use only the .png format. A special folder in the hidden folder openshot should be a + (perhaps for the user). All in the same place.
Have you forgotten to put what I have already suggest for (a GTKFileChooserButtun) ?
How do you do for changing of map in the same animation ?
Thanks.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Olivier,
1) Previous and Next marker issues: are you using "SDL" or "SDL Preview" from the preferences?
2) The create a folder dialog that does not listen for the ENTER key: Delayed until next release.
3) No drag and drop files into folders: Delayed until next release.
4) To debug the image sequence issue, I would need a TAR file with all the images and steps to reproduce.
5) The world map can use a PNG anywhere on the computer. It does not need to be in the /.openshot/ folder. I ran out of time to add the gtkFileChooser, so we need to a bug report for this feature, and delay until next release.

Revision history for this message
Olivier Girard (eolinwen) wrote :

Jonathan,
1) Right thought : the issue is only witht the "SDL Preview" and not with the "SDL" activate. I have tested with the last revision (463) on my LMDE and on Lucid and I confirm that this issue is only when "SDL Preview" is used in the Preferences.
2)okay
3)okay
4)I send you that soon as I changed of computer. It is a Youtube clip (a part) from a young singer.... Welcome in the French songs :) ^^
5)okay done here : https://bugs.launchpad.net/openshot/+bug/713629

Hey be careful if you go to the stadium tomorrow. I have seen that on the news and I don't know why but I have never imagined that you could have some (much) snow in Texas. :) :)

Revision history for this message
Olivier Girard (eolinwen) wrote :

Hum sorry for the delay. I was believing that I was having already send you the tar file.

Revision history for this message
Olivier Girard (eolinwen) wrote :

Is it normal that a folder create in the project tree containing a Video file appear too in the tab audio and Image ?

Revision history for this message
Olivier Girard (eolinwen) wrote :

I have found another nasty bug. This time with the new feature Add to the Timeline.
It is a project in Pal (720 x 576) composed of two titles animated, 24 clips like 18 DV (format avi) and 6 MPG. I put the exact denomination for the first type.
Already, 4 files are on the timeline put with the same way without none problem.
After, to have play with the play-head, I have put the other with the feature Add to the Timeline either 12 avi and 4 MPG. After selection, in the dialog, I select the first clip for precise the setting and surprised I have not access at those ones. I have try all the clips and each time it is the same issue. I note at the top left that the logo is not present too.
In the terminal i have the following error :
on_frmMain_key_press_event
Traceback (most recent call last):
  File "/home/olivier/bazaar/openshot/openshot/windows/MainGTK.py", line 4009, in on_mnuAddToTimeline_activate
    self.frmAddToTimeline = AddToTimeline.frmAddToTimeline(form=self.form, project=self.project, selected_files=selected_files)
  File "/home/olivier/bazaar/openshot/openshot/windows/AddToTimeline.py", line 54, in __init__
    self.refresh()
  File "/home/olivier/bazaar/openshot/openshot/windows/AddToTimeline.py", line 187, in refresh
    match_iter = self.search_tree(self.OSTreeFiles.store, self.OSTreeFiles.store.iter_children(None), self.search_match, (1, "%s" % parent_name))
AttributeError: frmAddToTimeline instance has no attribute 'search_tree'

Revision history for this message
Olivier Girard (eolinwen) wrote :

The project before the fail multiple import

Revision history for this message
Olivier Girard (eolinwen) wrote :

And the characteristic of the dv/avi file. It is surprising because I have used a lot of time this tool and until now I never had some problems with.

Revision history for this message
Olivier Girard (eolinwen) wrote :

I must precise that this length of the files is not huge (the more big have less 3min 40 sec).
I have closed my window and re-open, same thing.
It looks that there is a problem with the calculation of the total length so I have try selecting a group of the file.
After several try, I have a functional dialogue (with access at all the settings) with 16 files. If I had one or two other, the issue comes back.
When the issue comes back, I have always the same error and nothing when I have the 16 files.

n_frmMain_key_press_event
Traceback (most recent call last):
  File "/home/olivier/bazaar/openshot/openshot/windows/MainGTK.py", line 4009, in on_mnuAddToTimeline_activate
    self.frmAddToTimeline = AddToTimeline.frmAddToTimeline(form=self.form, project=self.project, selected_files=selected_files)
  File "/home/olivier/bazaar/openshot/openshot/windows/AddToTimeline.py", line 54, in __init__
    self.refresh()
  File "/home/olivier/bazaar/openshot/openshot/windows/AddToTimeline.py", line 187, in refresh
    match_iter = self.search_tree(self.OSTreeFiles.store, self.OSTreeFiles.store.iter_children(None), self.search_match, (1, "%s" % parent_name))
AttributeError: frmAddToTimeline instance has no attribute 'search_tree'
on_btnCancel_clicked
on_frmMain_key_press_event
on_btnCancel_clicked

Revision history for this message
Olivier Girard (eolinwen) wrote :

We should create a protocol of test and launch punctually some campaign tests. No ?
It will be more useful for us and the users. We can not all test unfortunately.

Revision history for this message
Olivier Girard (eolinwen) wrote :

Another issue/bug (?) with a new project for a slideshow.
I import 120 images of 2.4 Mo one in the same time. Openshot becomes gray for a while but I have no crash and all the images are imported. I have forgotten to precise that before I have modified in the Preferences the length of the Imported Image to 5 at 8. I see that the length displayed in the Project Tree is always stay at 5. she should be at 8.

Revision history for this message
Olivier Girard (eolinwen) wrote :

I have had something a bit strange, not a crash but more an issue playing with the zoom bar and the play-head.
Like you can see on the screenshot, I have imported all the previous images. I have got down my zoom bar at 2 secondes.
I wish to move the play-head to the two first image that I have put at 3.5 seconds of the begin. I wish to put an animated title before. I try to move the play-head until the first picture and Openshot becomes gray, nothing is done and after a while, he becomes normal and the play-head is at the desire location .Nothing in the terminal. All the system was locked, Impossible to record (the cursor was an hand) and even impossible to change of desktop. Until all becomes normal.

Revision history for this message
Olivier Girard (eolinwen) wrote :

I don't know if it is a issue or not. When we use always the dialogue Add to the TImeline. If I attempt to select several images with, I wish to personalize for each Image the type of Transition, can I do that. If yes, we have a issue with. Like In the screencast, I select the first picture and I apply her a Transition (here Dissolution). Now, I select the second picture and I wish for her another type of transition (saying circle) I apply her , I do this operation for another one and after I wish to check if the first image have well the transition that i have given at the beginning aka Dissolution. And I see that they have all the last transition selected.

Revision history for this message
Olivier Girard (eolinwen) wrote :

I note too when I use the preview that each time that the play head comes from a transition in a new picture,do a little pause (in fact stop and re-start, it is during a very short time but enough for showing it.
I have try to do a screencast but the framerate is too slow and I re-try to do one tomorrow with another software.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Olivier,
Here are my comments for you:

1) There were 2 different bugs in the 'Add to Timeline' you found. I was caused by selecting a "folder". I was caused by trying to find the parent of items (i.e. more folder code). Both are fixed, and it should not break anymore.

2) SDL Preview pauses when you seek and the video is still playing. This is a MLT issue, and is addressed in newer versions of MLT.

3) The Add to Timeline dialog only allows for a single transition to be applied to all clips, or random, which changes it for each clip.

4) The length of all images is 5 minutes, which is what the project files tree is showing. The default image length is used to trim down the 5 minute clip to only 7 seconds (etc...). So, this is just a little confusing, but it's working correctly.

5) Yes, the folders are always shown, regardless of the filters used (such as image, audio, or video). This is a bit tricky to fix, so we'll have to address this at a later point.

6) I agree... we do need to create a standard testing document, and try and make our testing more uniform. I would also like to create some automated unit tests. Maybe we can discuss this after this release is done. =)

Thanks for all the help testing! I think we have solved all these misc bugs, so I'm going to mark this report as completed.
-Jonathan

Changed in openshot:
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Olivier Girard (eolinwen) wrote :

That's okay for me.

moimael (moimael)
Changed in openshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.