Error in SQL when selecting Management>Displays [DisplayGroupAuth]

The selection of licensed displays is intentional because starting with Xibo 1.2.1, if you have given your users access to the Management -> Displays menu (and your users aren't Super Admins) then they should only see licensed displays they have been given permissions to modify. That means you can then setup Xibo to allow ordinary users access to modify the default layout on a subset of the dispalys.

What's not working here is the override that allows Super Admins to see unlicensed displays so that they can license them and assign permissions.

@Dan: FYI, the install on unittest is from before the display permission changes were merged so doesn't display this behaviour. I've confirmed it on my production 1.2.1 install by revoking a license logged in as xibo_admin and the display disappears from the listing.

I've had a quick look. My feeling is the fix proposed by the OP is wrong as it will allow non-admin users to edit all displays.

What I think needs to be done is at
http://bazaar.launchpad.net/~xibo-maintainers/xibo/biela/view/206/server/lib/pages/display.class.php#L370

needs an "and user is not an admin" clause on it, so that if the user is an admin then it falls straight through past the continue as normal?

@Alex - I think I agree with the OP, I can't think of a good reason why a non-admin user shouldn't be able to edit a display that is not licensed?

An alternative strategy would be for DisplayGroupAuth to filter on licenses = 0 if it is not an admin user?

module_user_general line 724 -> move to line 727?

Because as an admin you might temporarily unlicense a display that is out of
use?

Or to flip it around, why should they be able to.

Also doesn't the same function govern the displays you see in the schedule.
We certainly don't want unlicensed displays turning up there.

Alex

Good point on the schedule - hadn't thought of that. I guess your suggestion would be the best thing to do then.

Patched display.class.php file which needs to go in your server directory under lib/pages folder replacing the existing file there.

1.2.1.1 tar/zip files will replace the live versions in the next 30 minutes or so.