Launchpad itself

Diff overlay close button doesn't work

Bug #720122 reported by j.c.sackett
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
j.c.sackett
Launchpad itself 11.04

Bug Description

Take a look at https://code.launchpad.net/~lifeless/launchpad/bug-704446-db. When you click the diff link to bring up the overlay, a close button is in the top right corner of the overlay. Clicking this button does nothing; there's no way to dismiss the overlay.

Related branches

lp://qastaging/~jcsackett/launchpad/diff-overlay-close
Brad Crittenden (community): Approve (code)
Diff: 25 lines (+10/-0)
1 file modified
lib/lp/code/javascript/branchmergeproposal.diff.js (+10/-0)
j.c.sackett (jcsackett)
Changed in launchpad:
assignee: nobody → j.c.sackett (jcsackett)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12627 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12627>.

Changed in launchpad:
milestone: none → 11.04
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Robert Collins (lifeless) wrote :

qa-untestable because: its currently broken, and pages this diff affects on - e.g. bug pages - are working fine, but its a lot of effort to setup a new testable diff on qastaging. we wouldn't revert this change anyway as long as it doesn't make things worse - and it doesn't.

tags: added: qa-untestable
removed: qa-needstesting
Robert Collins (lifeless)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.