Launchpad itself

Elements are not closed on bug page source

Bug #728609 reported by James Ferguson on 2011-03-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Launchpad itself	Fix Released	Critical	Unassigned	Launchpad itself 11.04
	lazr.restful	Fix Released	Critical	Unassigned	lazr.restful 0.17.4

Bug Description

As of 2011-03-02, the bug page source has unclosed elements. The xhtml in the json is not escaped.

Any bug page is a good example. e.g. https://bugs.launchpad.net/linux/+bug/651785

This is a significant new issue because some browser user scripts fetch bug pages using XMLHttpRequest objects and then make use of the .responseXML member. This member is now null, presumably because the bug pages cannot be parsed as XML. Formerly working script is attached to this bug (comment #2)

These user scripts are an integral part of our process in the OEM Mainstream systems team, so this is a very important issue for us. Workarounds would include either allowing the user selection of columns in bug searches, or help developing user scripts which use the Launchpad API rather than doing full bug page gets and extracting data from them...

Thanks.

See original description

Tags:

Related branches

lp://qastaging/~sinzui/lazr.restful/json-not-xhtml-0

Merged into lp://qastaging/lazr.restful at revision 177

Leonard Richardson (community): Approve on 2011-03-07

Steve Magoun (smagoun) on 2011-03-03

tags:

added: oem-services

Revision history for this message

Robert Collins (lifeless) wrote on 2011-03-03:

Escalated via stakeholders list.

Changed in launchpad:
status:	New → Triaged
importance:	Undecided → Critical
tags:	added: escalated

Revision history for this message

James Ferguson (jamesf) wrote on 2011-03-03:

example script Edit (16.3 KiB, application/x-javascript)

This script worked on 2011-03-01 (unless I'm mistaken and it was the day before)

If someone knowledgeable can show me how to use the API in such a script instead, that would be great too.

description:

updated

Curtis Hovey (sinzui) on 2011-03-03

Changed in launchpad:
assignee:	nobody → Curtis Hovey (sinzui)

Revision history for this message

Curtis Hovey (sinzui) wrote on 2011-03-03:

The project is the xhtml in the javascript. All angle-brackets and ampersands must be escaped in attributes and script blocks. We can try to place the scripts in <![CDATA[...]]> which kills the TAL engine or address bug 684430.

The link elements in the head are fine. I believe you save the page from your browser. Firefox and Chromium rewrite empty tags to make them suck.

description:

updated

Revision history for this message

Robert Collins (lifeless) wrote on 2011-03-03: Re: [Bug 728609] Re: Elements are not closed on bug page source

On Fri, Mar 4, 2011 at 10:09 AM, Curtis Hovey
<email address hidden> wrote:
> The project is the xhtml in the javascript. All angle-brackets and
> ampersands must be escaped in attributes and script blocks. We can try
> to place the scripts in <![CDATA[...]]> which kills the TAL engine or
> address bug 684430.

the xhtml is new, lets drop it.

Curtis Hovey (sinzui) on 2011-03-03

Changed in launchpad:
status:	Triaged → In Progress

Curtis Hovey (sinzui) on 2011-03-03

Changed in launchpad:
milestone:	none → 11.03

Revision history for this message

Curtis Hovey (sinzui) wrote on 2011-03-07:

This is fixed in lazr.restful 0.17.3. We need a new egg to release this fix.

Changed in launchpad:
status:	In Progress → Fix Committed

Robert Collins (lifeless) on 2011-03-08

Changed in lazr.restful:
status:	New → Fix Committed
Changed in launchpad:
status:	Fix Committed → In Progress
Changed in lazr.restful:
assignee:	nobody → Curtis Hovey (sinzui)
importance:	Undecided → Critical

Revision history for this message

Robert Collins (lifeless) wrote on 2011-03-08:

I've updated the metadata to reflect the two projects involved here.

Revision history for this message

Launchpad QA Bot (lpqabot) wrote on 2011-03-10:

Fixed in stable r12565 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12565>.

tags:

added: qa-needstesting

Curtis Hovey (sinzui) on 2011-03-10

Changed in launchpad:
status:	In Progress → Fix Committed
tags:	added: qa-ok removed: qa-needstesting
Changed in lazr.restful:
milestone:	none → 0.17.4

Curtis Hovey (sinzui) on 2011-03-10

Changed in launchpad:
status:	Fix Committed → Fix Released

Revision history for this message

James Ferguson (jamesf) wrote on 2011-03-10:

Perhaps this is what I get for trying to report a bug with some analysis. The bug from my (user) perspective is that user (greasemonkey) scripts can no longer be used to fetch LP bug pages via XMLHttpRequest, and that bug remains. The bug page is not parseable so the DOM object is null and can't be used.

Robert Collins (lifeless) on 2011-03-10

Changed in launchpad:
status:	Fix Released → Fix Committed
Changed in lazr.restful:
status:	Fix Committed → Fix Released

Curtis Hovey (sinzui) on 2011-03-10

Changed in launchpad:
milestone:	11.03 → 11.04

Revision history for this message

James Ferguson (jamesf) wrote on 2011-03-10:

Ignore comment #8. The issue is fixed, but I was mislead by a mistake in the bug status, expecting it to be visible in LP. The issue is fixed in qastaging.launchpad.net.

Robert Collins (lifeless) on 2011-03-10