process mail shouldn't oops if dkim domain doesn't match the sender
Bug #728827 reported by
Tim Penhey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Tim Penhey | ||
Bug Description
Currently the handle incoming email method logs a warning. This is treated by the cronscript infrastructure as an OOPS.
Related branches
lp://qastaging/~thumper/launchpad/mail-header-oops
- Robert Collins (community): Approve
- Ian Booth (community): Approve (*code)
-
Diff: 241 lines (+91/-30)4 files modifiedlib/lp/services/mail/incoming.py (+36/-20)
lib/lp/services/mail/tests/incomingmail.txt (+6/-6)
lib/lp/services/mail/tests/test_incoming.py (+44/-1)
lib/lp/testing/factory.py (+5/-3)
Revision history for this message
| Martin Pool (mbp) wrote Re: [Bug 728827] [NEW] process mail shouldn't oops if dkim domain doesn't match the sender | #1 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| milestone: | none → 11.04 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I don't know if there is already one and I missed it, but maybe the
fact that warnings cause an oops ought to go into the architecture
guide?
I think it would be better to downgrade them to eg 'info' rather than
taking them out.
Martin