Authority Record UI issues

Bug #732681 reported by George Duimovich
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Mike Rylander

Bug Description

EG 2.0.2 (test server)
Ubuntu 10.04 / PG 8.4
OpenSRF 1.6.2

Possible bug but not certain about further debugging against these UI issues:

1. Right click in MARC Editor doesn't display link to Authority functionality
http://geoscan.ess.nrcan.gc.ca/evergreen/images/right-click-no-authority-link.png

2. Manage Authorities: results don't line up or give proper menu links. Actions menu items do not work:
http://geoscan.ess.nrcan.gc.ca/evergreen/images/manage-authorities.png

My data (pg_dump of our authority.record_entry table) FWIW (500K+ records):
http://geoscan.ess.nrcan.gc.ca/evergreen/auth/nrcan-are.sql.gz

I have re-installed 2.0.2 with no change of outcome above; my next step is to redo the entire 1.6.1.4 upgrade to 2.0.3 to see if I can reproduce.

In the interim, advise to further investigate welcome.

Revision history for this message
Dan Scott (denials) wrote :

Thanks for the massive set of MARC records! I had asked for just a few samples, but I'm trying to load your complete set on my laptop now.

It would be helpful to me if you could, on your test system:

1) try loading just a few authority records to see if the quantity of records and search response times (or lack thereof) might be introducing some problems

2) Check the JavaScript Console in the staff client (Admin -> Developer -> JavaScript Console) to see if there are glaring errors being reported, particularly in the "Manage authorities" interface.

Changed in evergreen:
assignee: nobody → Dan Scott (denials)
Revision history for this message
George Duimovich (george-duimovich) wrote :

Re: massive set -- very junky too. I expect to be doing lots of batch removals as somewhere in one of our previous ILS's history there was an "automatic authorities" features that they used for some time. We'll separate wheat from chaff soon.

Regarding js console, performing these steps:

Open Manage Authorities > Perform search for Subject term > Page forward

The JavaScript Console reports no errors, but some minor (?) warnings like:
"Expected declaration but found..."
Unknown property '-moz-outline-style'. Declaration dropped
etc.

Revision history for this message
Dan Scott (denials) wrote : Re: [Bug 732681] Re: Authority Record UI issues

I stopped trying to load the complete set and just loaded the first
1000, and wow - there's a lot of 4xx and 5xx entries in there - the UI
might need some tweaking on the MARC Editor context field popup. But
it worked on Fedora 14 / PostgreSQL 8.4 / Evergreen 2.0.3, in both the
MARC Editor and Manage Authorities interfaces.

I'll crank up to 50,000 records and try loading those on my laptop to
see if the delay due to large number of records introduces a problem.

Revision history for this message
Dan Scott (denials) wrote :

Loaded 50,000 records on my laptop and it's all still working well (albeit the records that have 16 4xx/5xx fields really do a number on the MARC Editor UI; you need to scroll up and down the list).

I'll try loading these onto a clean VM image for the 2.0.3 release and see what happens.

Revision history for this message
George Duimovich (george-duimovich) wrote :

Just upgraded to 2.0.3 (from 2.0.2), and I have the same symptoms. Also, no errors reported in the js console.

Next step -- redo from 1.6.0.4 scratch entire upgrade again.

Revision history for this message
George Duimovich (george-duimovich) wrote :

Minor update FWIW -- Merge record action item does appear to work for me. But Edit and delete do not.

Revision history for this message
Dan Scott (denials) wrote :

Performed a clean install of Evergreen 2.0.3 on a completely clean Debian Squeeze machine, loaded 50,000 of your authority records, and could not reproduce any of your reported problems. I suspect you have a configuration problem on your server.

Revision history for this message
George Duimovich (george-duimovich) wrote :

FWIW, I go the same symptoms with complete redo of 1.6.1.4 > 2.0.3 system. Restarted with newly refreshed /openils directory, database, and redo of OpenSRF 1.6.2 install. Won't get back at this for a couple of days, but let me know if you've got any other thoughts on what to check, etc.

Revision history for this message
Jason Etheridge (phasefx) wrote :

I'm trying to reproduce this on a public server, but have seen it elsewhere. When I stepped through the javascript with Venkman, it looked as if Mozilla would lose track of what code was running in the pop-up event handler, right after the dojo.forEach that loops through the authority records. This causes the normal context handler to function, giving you the copy/paste menu instead of the authority dialog.

Revision history for this message
Mike Rylander (mrylander) wrote :

As a datapoint, replacing dojo.forEach with for(;;) did not change the situation on another server exhibiting this behavior, so it's not Dojo or it's crazy closure dances.

Revision history for this message
George Duimovich (george-duimovich) wrote :

Update -- re-ran upgrade steps for 1.6.0.4 system to 2.0.4 (on Ubuntu 10.4 with OpenSRF 1.6.2)

As a complete wildcard, I only included our III sourced Authority records (much less and better quality records).

No success - and same symptoms as originally reported.

Re: local configuration -- can't seem to find any local configuration to account for this error, so let me know if anybody has anything else for me to check. Otherwise I think I'll leave this issue for our eventual production upgrade and then open a support ticket if it happens there to.

Revision history for this message
George Duimovich (george-duimovich) wrote :

Thanks to James Fournie from BC Sitka for providing the a fix for us over beer at Leon's. We found a few other crews with similar symptoms so James mentioned that he had to re-ingest the authority records since his didn't have the 2.0 record id data

I checked our authority records and we didn't have any record id's either after our upgrade from 1.6.1.4 to 2.0.4, so I followed James suggestion to trigger the re-ingest by running a simple update query against the authority.record_entry table. The re-ingest will add the new 901 data with record id's.

This fixed my mangled display issue (via "Manage Authorities") and also now allows me to access authorities in the MARC editor via "right click".

Thanks James!

Revision history for this message
Dan Scott (denials) wrote :

Ah - that makes so much sense. The database functions evergreen.maintain_control_numbers() and evergreen.maintain_901() need to be invoked to ensure that the 003 field and 901 $c subfield exist in each authority record. I didn't hit that when I loaded your sample records because, of course, when I imported them into a shiny new 2.0 database these functions were invoked at import time so it changed the records to suit.

A SQL statement that would hit every record in authority.record_entry to ensure that these functions get invoked would be "UPDATE authority.record_entry SET active = active WHERE 1 = 1;". Maybe overkill, but better safe than sorry.

Also - clearly I should add some defensive coding to the authority interfaces to handle the case where the authority record does not have a 901 $c or 003!

Revision history for this message
Mike Rylander (mrylander) wrote :

I'll add this to the 1.6-2.0 upgrade script ... it will take a while to run, but at least authorities will work.

Revision history for this message
Dan Scott (denials) wrote :

Mike: were you planning to add the UPDATE statement to 1.6-2.0 before cutting 2.0.6? If so, PING! :)

Changed in evergreen:
milestone: none → 2.0.6
status: New → In Progress
assignee: Dan Scott (denials) → Mike Rylander (mrylander)
Revision history for this message
Mike Rylander (mrylander) wrote :

As promised, the upgrade script will says

UPDATE authority.record_entry SET active = active;

now.

Changed in evergreen:
status: In Progress → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.