poppy-sftp holds transactions open forever
Bug #733033 reported by
William Grant
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
William Grant | ||
Bug Description
PoppyFileWriter's validateGPG starts a transaction, but never aborts or commits it. This leaves a transaction open until the daemon is killed -- resulting in the connection being reaped on production.
Related branches
lp://qastaging/~wgrant/launchpad/poppy-transaction-unbreakage
- Tim Penhey (community): Approve (code)
- Steve Kowalik (community): Approve (code*)
-
Diff: 221 lines (+29/-10)11 files modifiedlib/lp/bugs/externalbugtracker/base.py (+1/-1)
lib/lp/bugs/externalbugtracker/bugzilla.py (+1/-1)
lib/lp/bugs/externalbugtracker/debbugs.py (+1/-1)
lib/lp/bugs/externalbugtracker/mantis.py (+1/-1)
lib/lp/bugs/externalbugtracker/rt.py (+1/-1)
lib/lp/bugs/externalbugtracker/trac.py (+1/-1)
lib/lp/bugs/scripts/checkwatches/base.py (+1/-1)
lib/lp/bugs/scripts/checkwatches/tests/test_base.py (+2/-2)
lib/lp/poppy/tests/test_twistedftp.py (+17/-0)
lib/lp/poppy/twistedftp.py (+2/-0)
lib/lp/services/database/tests/test_isolation.py (+1/-1)
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| Changed in launchpad: | |
| importance: | Critical → High |
| tags: | removed: regression |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| tags: | removed: soyuz-upload |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12581 <http://