Cannot build unminified launchpad.js.

Bug #733230 reported by Gavin Panella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gavin Panella

Bug Description

It's not possible to build an unminified launchpad.js any more. This would be very handy to have during development.

Related branches

Gavin Panella (allenap)
tags: added: build-infrastructure javascript
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 733230] [NEW] Cannot build unminified launchpad.js.

On Sat, Mar 12, 2011 at 1:35 AM, Gavin Panella
<email address hidden> wrote:
> Public bug reported:
>
> It's not possible to build an unminified launchpad.js any more. This
> would be very handy to have during development.

Sure it is - deryck has posted the recipe before on IRC. Its just an
environment variable.

I would close this bug when the docs are a little clearer on it.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
milestone: none → 11.04
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Gavin Panella (allenap) wrote :

> Sure it is - deryck has posted the recipe before on IRC. Its just an
> environment variable.

There's the JSFLAGS environment variable, but it didn't work. The list
of files to be included in launchpad.js were coming partly from the
$(shell ...) lines below:

jsbuild: jsbuild_lazr bin/jsbuild bin/jssize $(BUILDOUT_BIN)
 ${SHHH} bin/jsbuild \
  $(JSFLAGS) \
  -n launchpad \
  -s lib/canonical/launchpad/javascript \
  -b $(LP_BUILT_JS_ROOT) \
  $(shell $(HERE)/utilities/yui-deps.py) \
  $(shell $(PY) $(HERE)/utilities/lp-deps.py) \
  lib/canonical/launchpad/icing/lazr/build/lazr.js

They were always returning the -min.js variants.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 733230] Re: Cannot build unminified launchpad.js.

On Sat, Mar 12, 2011 at 12:36 PM, Gavin Panella
<email address hidden> wrote:
>> Sure it is - deryck has posted the recipe before on IRC. Its just an
>> environment variable.
>
> There's the JSFLAGS environment variable, but it didn't work. The list
> of files to be included in launchpad.js were coming partly from the
> $(shell ...) lines below:
>
> jsbuild: jsbuild_lazr bin/jsbuild bin/jssize $(BUILDOUT_BIN)
>        ${SHHH} bin/jsbuild \
>                $(JSFLAGS) \
>                -n launchpad \
>                -s lib/canonical/launchpad/javascript \
>                -b $(LP_BUILT_JS_ROOT) \
>                $(shell $(HERE)/utilities/yui-deps.py) \
>                $(shell $(PY) $(HERE)/utilities/lp-deps.py) \
>                lib/canonical/launchpad/icing/lazr/build/lazr.js
>
> They were always returning the -min.js variants.

Ah! thanks for explaining.

Gavin Panella (allenap)
tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.