picker use large heading instead of body text
Bug #737709 reported by
Deryck Hodge
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Unassigned | ||
Bug Description
The font used in the sub heading on the overlay for adding team members is messed up. It's very large now. To reproduce:
1.) Go to any team page (e.g. https:/
2.) Click the green "Add member" link
3.) See the awful, too-big font in the overlay
Related branches
lp://qastaging/~sinzui/launchpad/picker-headings-0
- Benji York (community): Approve (code)
-
Diff: 1079 lines (+513/-494)5 files modifiedMakefile (+2/-2)
buildout-templates/bin/combine-css.in (+2/-1)
buildout-templates/bin/sprite-util.in (+2/-2)
lib/canonical/launchpad/icing/sprite.css.in (+494/-0)
lib/canonical/launchpad/icing/style-3-0.css (+13/-489)
| summary: |
- 'Add member' overlays for teams has bad font + picker use large heading instead of body text |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| milestone: | none → 11.04 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
The issue is really all pickers, but is most visible in the person picker when the instructions can be long. The instructions are a heading, but they should be body text. The picker's <h1> may need to be a <h2> because it is never the primary content of the document