Launchpad itself

LaunchpadScript fails to install feature controller

Bug #739986 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jeroen T. Vermeulen
Launchpad itself 11.04

Bug Description

LaunchpadScript.run now does:

    install_feature_controller(make_script_feature_controller(self.name))

However, make_script_feature_controller already installs its controller. And it returns None, so this just clears the feature controller.

Related branches

lp://qastaging/~jtv/launchpad/bug-739986
Steve Kowalik (community): Approve
Diff: 73 lines (+15/-10)
3 files modified
lib/lp/services/features/__init__.py (+7/-5)
lib/lp/services/scripts/base.py (+1/-2)
lib/lp/services/scripts/tests/test_feature_controller.py (+7/-3)
Jeroen T. Vermeulen (jtv)
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12644 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12644>.

tags: added: qa-needstesting
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.