FakeLogger doesn't quite conform to logging API
Bug #741585 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Jeroen T. Vermeulen |
Bug Description
There's a small difference between FakeLogger and python's native logging module: the "log" method is supposed to take the log level as its first argument. Fixing this will help cases where we pass any of our custom log levels and may or may not be talking to a FakeLogger.
Related branches
lp://qastaging/~jtv/launchpad/bug-741585
- Stuart Bishop (community): Approve
-
Diff: 205 lines (+74/-27)3 files modifiedlib/canonical/launchpad/utilities/looptuner.py (+18/-9)
lib/lp/archivepublisher/utils.py (+3/-2)
lib/lp/services/log/logger.py (+53/-16)
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12657 (http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12657) by a commit, but not testable.