"Mute bug mail" in new bug reports is odd
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Graham Binns |
Bug Description
Steps to reproduce:
1. visit an existing bug that you've never seen;
2. ensure that you're not subscribed to that bug, neither directly nor indirectly.
What happens:
In the right menu there are three buttons: "Subscribe", "Subscribe someone else" and "Mute bug mail". Since you can't receive mails about that bug report, I can't understand what "Mute bug mail" will do. What's more odd is that if you click the button, the text will change to "Unmute bug mail" and it gives you the idea that your action has had some effect.
I don't think (although I may be wrong) that the "Mute bug mail" has some visible effects if you are not subscribed to a bug, so the solution would be to either hide this button or, when you click it, popup a clear message: "You can't mute because you're not subscribed".
Related branches
- Данило Шеган (community): Approve
-
Diff: 127 lines (+78/-5)4 files modifiedlib/lp/bugs/browser/bug.py (+15/-0)
lib/lp/bugs/browser/configure.zcml (+6/-3)
lib/lp/bugs/browser/tests/test_bug_views.py (+56/-0)
lib/lp/bugs/templates/bug-portlet-subscribers.pt (+1/-2)
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Graham Binns (gmb) |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
I can confirm that clicking the link will have had some effect; if you later subscribe to one of the bug's BugTargets (e.g. if you subscribe to Launchpad bugs in this case) you'll never receive email about the muted bug because the mute is already in place.
However, I think that not showing the link at all when the user doesn't receive any emails about the bug in any way whatever is probably the least confusing course for the UI. So the link will appear if:
- The user is directly subscribed
- The user is subscribed via a duplicate
- The user is structurally subscribed
- The user is "also notified" (i.e. is BugTarget owner or bug supervisor)
- The user is already muted (in which case it will read "Unmute...")
Otherwise it won't be shown.