Don't present diff-generation link on +localpackagediffs if it can't be done
Bug #747202 reported by
Julian Edwards
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Raphaël Badin |
Bug Description
For some of the table rows, there's no base version in the data. This may be a problem with the data that won't occur in real life but nonetheless the page should not offer the "Compute differences from last common version" link. Instead, it should say that it can't do it because the base version is missing.
Related branches
lp://qastaging/~rvb/launchpad/dds-missing-base-version-747202
- j.c.sackett (community): Approve
-
Diff: 226 lines (+103/-11)4 files modifiedlib/lp/registry/browser/distroseriesdifference.py (+1/-0)
lib/lp/registry/browser/tests/test_distroseriesdifference_views.py (+89/-7)
lib/lp/registry/templates/distroseriesdifference-listing-extra.pt (+7/-3)
lib/lp/testing/factory.py (+6/-1)
tags: | added: derivation |
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in launchpad: | |
assignee: | nobody → Raphaël Victor Badin (rvb) |
tags: |
added: okneedstesting removed: derivation qa-needstesting |
tags: |
added: derivation qa-ok removed: okneedstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12780 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12780>.