Unreachable tests for hardwaredb
Bug #747532 reported by
j.c.sackett
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
j.c.sackett |
Bug Description
There are tests in lib/lp/
You can verify by running all tests for the hardwaredb module (bin/test -m lp.hardwaredb). Docs are run, stories are run, the stuff in scripts/tests never runs.
Related branches
lp://qastaging/~jcsackett/launchpad/hardwaredb-should-ignore-bad-data
- Данило Шеган (community): Approve
-
Diff: 181 lines (+73/-12)3 files modifiedlib/lp/hardwaredb/scripts/hwdbsubmissions.py (+25/-10)
lib/lp/hardwaredb/tests/test_hwdb_submission_validation.py (+35/-2)
lib/lp/services/scripts/base.py (+13/-0)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The easy workaround for this, of course, is moving those tests into hardwaredb/tests instead of hardwaredb/ scripts/ tests. Doing that causes the tests to pass, which may be sufficient to close this bug.
However, if those tests should be reachable regardless of where the tests directory the live in lives, then this bug should probably be updated.a