Structural subscription overlay sometimes rendering incorrectly on the page not as an overlay
Bug #751397 reported by
Brad Crittenden
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Brad Crittenden | ||
Bug Description
On the following pages the overlay is being rendered within the page, not as an overlay, and the 'Subscribe to bug mail' link is not shown.
https:/
https:/
Note that firefox does not use the Launchpad bug tracker and that Ubuntu has special rules.
The following *do* work as expected as they are a project and a distro that use LP for bug tracking with no special cases:
https:/
https:/
Related branches
lp://qastaging/~bac/launchpad/bug-751397
- Deryck Hodge (community): Approve (code)
-
Diff: 315 lines (+74/-45)9 files modifiedlib/lp/app/javascript/client.js (+23/-15)
lib/lp/app/javascript/lp.js (+2/-2)
lib/lp/app/javascript/tests/test_lp_collapsibles.js (+5/-3)
lib/lp/bugs/javascript/filebug_dupefinder.js (+2/-2)
lib/lp/bugs/templates/bugtarget-bugs.pt (+17/-14)
lib/lp/registry/javascript/structural-subscription.js (+12/-6)
lib/lp/registry/javascript/tests/test_structural_subscription.js (+10/-0)
lib/lp/soyuz/javascript/lp_dynamic_dom_updater.js (+2/-2)
lib/lp/testing/__init__.py (+1/-1)
| Changed in launchpad: | |
| assignee: | nobody → Brad Crittenden (bac) |
| status: | New → In Progress |
| importance: | Undecided → High |
Revision history for this message
| Brad Crittenden (bac) wrote | #1 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| milestone: | none → 11.04 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm actually seeing the problem now on staging and production but not qastaging.
Changes need to be made to some page templates when the 'Subscribe to bug mail' link is conditioned on the pillar using LP for bug tracking, for instance.