Support for editing notes in Serial Control

This feature is now available in user/dbwells/lp-796795_serial_note_improvements for question, comment, or committal.

Dan

Hey Dan, this seemed to work great when I tried it. I made what I think is a tiny aesthetic improvement if you want to try it: it shows one "close window" button for the window rather than one per note.

collab/senator/lp-796795_serial_note_improvements

Hello Lebbeous,

Thank you for the review and also for your contribution. Your code is a definite improvement.

I have pushed a further tweak based of your commit to the contrib branch you set up. This change restores the overall space and position of the close button while keeping the other improvements (appears once, shows even with no notes).

If you think it works, please feel free to push this all along. Otherwise, more changes are always welcome.

Thanks again,
Dan

Thanks Dan. It works nicely. Pushed to master as 0c2d1a7a9b.

I'm being conservative about backporting since 2.1 is in beta. I doubt it would really hurt to backport, but leaving that decision to others.