Last payment types possibly incorrect in 2.0+

Bug #817689 reported by Steve Callender
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.0
Fix Released
Undecided
Unassigned
2.1
Fix Released
Undecided
Unassigned
2.2
Fix Released
Undecided
Unassigned

Bug Description

The last payment types in 2.0+ are being stamped as bnm_payment for both cash payments and check payments. I believe this may be an oversight. Possibly someone copied these triggers from the bnm_payment and never adjusted the name.

On table money.cash_payment

    mat_summary_add_tgr AFTER INSERT ON money.cash_payment FOR EACH ROW EXECUTE PROCEDURE money.materialized_summary_payment_add('bnm_payment')
    mat_summary_del_tgr BEFORE DELETE ON money.cash_payment FOR EACH ROW EXECUTE PROCEDURE money.materialized_summary_payment_del('bnm_payment')
    mat_summary_upd_tgr AFTER UPDATE ON money.cash_payment FOR EACH ROW EXECUTE PROCEDURE money.materialized_summary_payment_update('bnm_payment')

And on money.check_payment

    mat_summary_add_tgr AFTER INSERT ON money.check_payment FOR EACH ROW EXECUTE PROCEDURE money.materialized_summary_payment_add('bnm_payment')
    mat_summary_del_tgr BEFORE DELETE ON money.check_payment FOR EACH ROW EXECUTE PROCEDURE money.materialized_summary_payment_del('bnm_payment')
    mat_summary_upd_tgr AFTER UPDATE ON money.check_payment FOR EACH ROW EXECUTE PROCEDURE money.materialized_summary_payment_update('bnm_payment')

The bnm_payment should be changed to cash_payment and check_payment accordingly, unless this was something that was done on purpose.

Tags: pullrequest
Revision history for this message
Steve Callender (stevecallender) wrote :
tags: added: pullrequest
Revision history for this message
Steve Callender (stevecallender) wrote :

I created a small patch to the SQL scripts. Someone will need to take a look and sign off on this though.

Revision history for this message
Mike Rylander (mrylander) wrote :

Pushed into master through 2.0 with upgrade scripts. Thanks, Steve!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
milestone: none → 2.2.0
Changed in evergreen:
milestone: 2.2.0alpha1 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.