Evergreen

Ugly things happen with more than 6 patron notes

Bug #824257 reported by Michael Peters
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Jason Etheridge
Evergreen 2.1.0
Declined for 2.2 by Jason Stephenson
Declined for Main by Jason Stephenson
2.0
Fix Released
Undecided
Unassigned
Evergreen 2.0.10
2.1
Fix Released
Undecided
Unassigned
Evergreen 2.1.0

Bug Description

Evergreen 2.0.4

The attached screenshot sums this up better than I can describe. Basically, when you have more than 6 patron notes some nasty things start happening. This prevents you from deleting the notes, etc.

Is there anything that can be done to prevent this? Obviously, it won't be typical for a patron to have quite this many notes but we do often have patrons with 8 to 10 notes on their account.

Revision history for this message
Michael Peters (mrpeters) wrote :
Revision history for this message
Michael Peters (mrpeters) wrote :

Pushed a fix which sets each "stack" to a min-height of 50px and auto overflow. This prevents the buttons from rendering below the stack row.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=fc5d73ddc613e9778d0f7058632c0e0be4440189

tags: added: pullrequest
Revision history for this message
Jason Etheridge (phasefx) wrote :

Ha, I got the itch and did this at the same time as you:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=1dd6313457ce172e5f4a0d396bb981dc089908e8

I think the min-height is key

Revision history for this message
Jason Etheridge (phasefx) wrote :

Michael, I think my version works better with long notes that wrap over several lines. It's not doing the scroll bars per note.

Revision history for this message
Jason Etheridge (phasefx) wrote :

Ah, knew there was a reason not to include URL's with commit hashes; force-pushing changes commit hashes.
Michael's new branch at user/mrpeters-isl/notes_overflow_fix @ working/Evergreen.git

Mike Rylander (mrylander)
Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Revision history for this message
Jason Etheridge (phasefx) wrote :

pushed to master, rel_2_1, and rel_2_0

Changed in evergreen:
status: Confirmed → Fix Committed
Jason Stephenson (jstephenson)
Changed in evergreen:
milestone: none → 2.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.