Issuing the 'affects' command before a 'bug' command while editing multiple bugs using the email interface shouldn't crash.

Bug #83426 reported by Diogo Matsubara
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
j.c.sackett

Bug Description

As seen in the following traceback, the email handler crashed because the affects command was specified before the bug command.

This should just work.

> To: <email address hidden>
> Subject: Cron <launchpad@gangotri> python
> |_/srv/launchpad.net/production/launchpad/cronscripts/process-mail.py -q
> Date: Wed, 31 Jan 2007 13:15:13 +0000 (GMT)
> Reply-To: <email address hidden>
> X-Spambayes-Classification: ham; 0.00
>.
> 13:15:11 ERROR An exception was raised inside the handler:
> http://librarian.launchpad.net/6004949/pwpYrzouiXdZYFOYyUFV931DoB6.txt
> -> http://librarian.launchpad.net/6004950/70RYLb8Gw4Ii6uH81JHzIDO1wLq.txt ('NoneType' object has no attribute 'bugtasks')

OOPS-780S232
Exception type AttributeError
Exception value 'NoneType' object has no attribute 'getBugTask'

Related branches

Changed in malone:
status: Unconfirmed → Confirmed
description: updated
Curtis Hovey (sinzui)
Changed in malone:
status: Confirmed → Triaged
importance: Undecided → Low
importance: Low → High
tags: removed: fix-it-friday
Revision history for this message
Robert Collins (lifeless) wrote :

Because we support
bug foo
affects bar
bug quux
affects zany

we probably want to report an error to the user, like we do on other un-executable mails. Not OOPS matters too of course ;)

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 83426] Re: Issuing the 'affects' command before a 'bug' command while editing multiple bugs using the email interface shouldn't crash.

If this previously generated a clean error and now gives an oops, I
might have broken this when refactoring email authentication. If so,
sorry, and it seems like a test is missing.
--
Martin

Revision history for this message
Robert Collins (lifeless) wrote :

No, this bug is ancient ;)

Changed in launchpad:
importance: High → Critical
j.c.sackett (jcsackett)
Changed in launchpad:
assignee: nobody → j.c.sackett (jcsackett)
j.c.sackett (jcsackett)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
milestone: none → 11.04
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.