LAVA Dispatcher

AttributeError: 'LavaClient' object has no attribute 'android_result_dir'

Bug #873043 reported by Paul Larson on 2011-10-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	LAVA Dispatcher	Fix Released	Critical	Spring Zhang	LAVA Dispatcher 2011.10
	Linaro Android	Fix Released	Undecided	Frans Gifford

Bug Description

in __init__.py:
    @property
    def lava_result_dir(self):
        if self.client.android_result_dir:
            return self.client.android_result_dir
        return self.config.get("LAVA_RESULT_DIR")

I'm not entirely sure why this was added, but since the non-android client doesn't have a android_result_dir() method, this will fail for everything but android. For that matter, why does the android result dir need to be a different method at all? As far as I can tell, the only difference is that the android_result_dir() method creates and sets permissions on the result directory first.

Related branches

lp://qastaging/~qzhang/lava-dispatcher/fix-873043

Merged into lp://qastaging/lava-dispatcher at revision 131

Yongqin Liu: Approve on 2011-10-13

Paul Larson (pwlars) on 2011-10-12

Changed in lava-dispatcher:
importance:	Undecided → Critical
assignee:	nobody → Spring Zhang (qzhang)
milestone:	none → 2011.10

Revision history for this message

Zach Pfeffer (pfefferz) wrote on 2011-10-12:

Frans, would you mind taking a look at this?

Changed in linaro-android:
assignee:	nobody → Frans Gifford (fgiff)

Revision history for this message

Paul Larson (pwlars) wrote on 2011-10-12:

@zach, @frans: This isn't in the currently deployed version of lava-dispatcher, so you shouldn't be getting hit by it right now.

Revision history for this message

Spring Zhang (qzhang) wrote on 2011-10-13:

android_result_dir is a member of AndroidLavaClient, it's recreated as a random dir under lava_result_dir when AndroidLavaClient initialization to fix the issue that all Android dispatcher share a same result dir. So when it is AndroidLavaClient, it will return the random dir.
I'll add a determination for AndroidLavaClient in code.

Spring Zhang (qzhang) on 2011-10-14

Changed in lava-dispatcher:
status:	New → Fix Committed
Changed in linaro-android:
status:	New → Fix Committed

Fathi Boudra (fboudra) on 2011-10-21

Changed in lava-dispatcher:
status:	Fix Committed → Fix Released

Frans Gifford (fgiff) on 2011-11-01

Changed in linaro-android:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.