OpenLP

OpenLyrics export non-compliant for split verses

Bug #876211 reported by Samuel Findlay on 2011-10-17

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenLP	Fix Released	High	Phill	OpenLP 2.0 "Original Adam"

Bug Description

OpenLP 1.9.7

When exporting to OpenLyrics there is a case where the file created is non-compliant to the OpenLyrics standard.
In OpenLP, the only way to obtain a 'hard break' (split verse across two or more slides) is to create separate consecutive 'verses' but number them the same:
---[Verse:1]---
Amazing grace! How sweet the sound
That saved a wretch like me;
---[Verse:1]---
I once was lost, but now am found,
Was blind, but now I see.

When exported to OpenLyics, this results in two verses both with name="v1". However, the OpenLyrics spec says "There shouldn’t be two or more verses the same name." The correct way to indicate split verses in OpenLyrics is with name="v1a", name="v1b", etc.
<http://openlyrics.info/dataformat.html#verse-name>

While on this topic, should we talk about better ways to specify 'hard breaks' within OpenLP?

Tags:

Related branches

lp://qastaging/~phill-ridout/openlp/openlyric_split

Merged into lp://qastaging/openlp at revision 2080

Raoul Snyman: Approve on 2012-10-08

Tim Bentley: Pending requested 2012-10-08

OpenLP Core: Pending requested 2012-09-25

Samuel Findlay (sfindlay) on 2011-10-17

tags:

added: song-export

Revision history for this message

Andreas Preikschat (googol-deactivatedaccount) wrote on 2011-10-23:

> While on this topic, should we talk about better ways to specify 'hard breaks' within OpenLP?
Maybe....

Changed in openlp:
importance:	Undecided → High
milestone:	none → 1.9.8
status:	New → Confirmed

Revision history for this message

Samuel Findlay (sfindlay) wrote on 2011-10-24:

>> While on this topic, should we talk about better ways to specify 'hard breaks' within OpenLP?
> Maybe....
Perhaps the [===] syntax used in custom slides could be brought over to songs?

Andreas Preikschat (googol-deactivatedaccount) on 2011-12-23

Changed in openlp:
milestone:	1.9.8 → 1.9.9

Revision history for this message

mahfiaz (mahfiaz) wrote on 2012-03-18:

Samuel's comment is slightly outdated. Songs now have [---] to mark soft breaks and as before, one could use repeated same verse marker for hard breaks.
Unfortunately this complicates the situation.
"Lettering" all verse parts as v1a, v1b, v1c is easy. But how to mark soft breaks in OpenLyrics?
Since OpenLyrics is our main export format, we cannot allow data loss on suggested export-import cycle.

Revision history for this message

Samuel Findlay (sfindlay) wrote on 2012-03-18:

Soft breaks are already marked in OpenLyrics. As of at least build 1893, we use this syntax:
<verse name="v1">
<lines break="optional">...</lines>
<lines>...</lines>
</verse>

This doesn't seem to conflict with using v1a, v1b, v1c for hard breaks?

Revision history for this message

mahfiaz (mahfiaz) wrote on 2012-03-18:

Oh, thanks Samuel, I didn't know that. Then this should be fixable.

Jonathan Corwin (j-corwin) on 2012-03-22

Changed in openlp:
milestone:	1.9.9 → none

Revision history for this message

Meinert Jordan (m2j) wrote on 2012-04-04:

Hmm,
so <lines break="optional">...</lines> means, that there is a optional break after the lines block?

In the end we need to have theese kinds of page brakes:
- hard page break (will be implemented as parte e.g. v1a, v1b)
- preferred page break ([---], or call it optional)
- prohibited break

The prohibited break is necessary to make shure, that diffenent parts which are sung at the same time appear on the same slide. It has the similar effect like adding a preferred page break at all other positions (but you might want to use both kinds in the same song).

Samuel, would you please explain the exact semantic of the break attribute?

Changed in openlp:
assignee:	nobody → Meinert Jordan (m2j)

Revision history for this message

Samuel Findlay (sfindlay) wrote on 2012-04-04:

As the break attribute is not mentioned in the OpenLyrics v0.7 docs on their website, I think it's being added to the (draft) v0.8 precisely for defining the soft/optional/preferred break we use in OpenLP.

Prohibited break - I don't this is defined in either OpenLP or OpenLyrics. Are you suggesting it as a new feature?

Revision history for this message

Samuel Findlay (sfindlay) wrote on 2012-07-10:

Meinert, are you working on this?

I have added new wishlist bug "Add prohibited page break to song verses" https://bugs.launchpad.net/openlp/+bug/1022978

Phill (phill-ridout) on 2012-08-03

Changed in openlp:
assignee:	Meinert Jordan (m2j) → phill (phill-ridout)

Phill (phill-ridout) on 2012-08-03

Changed in openlp:
status:	Confirmed → In Progress

Raoul Snyman (raoul-snyman) on 2012-09-05

Changed in openlp:
milestone:	none → 1.9.12

Raoul Snyman (raoul-snyman) on 2012-09-14

Changed in openlp:
milestone:	1.9.12 → 2.0

Revision history for this message

Phill (phill-ridout) wrote on 2012-10-10:

http://support.openlp.org/issues/1239

Tim Bentley (trb143) on 2012-10-10

Changed in openlp:
status:	In Progress → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.