Dates Closed editor: User input not monitored

Bug #888604 reported by Jim Frey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.1
Won't Fix
Undecided
Unassigned
2.2
Won't Fix
Medium
Unassigned
2.3
Fix Released
Medium
Unassigned
2.4
Fix Released
Medium
Unassigned

Bug Description

When users enter date spans in to the Closed Dates Editor, the system doesn't perform checks to verify accuracy. It is possible to enter a CLOSE_END date that is less than/prior to the CLOSE_START date. For example, when creating a record listing a closing over New Year, users may enter CLOSE_START as "2011-12-31" and CLOSE_END as "2011-01-01" (a whole year earlier).

Tags: pullrequest
Revision history for this message
Jim Frey (jfrey) wrote :

Should have mentioned: Using EG version 1.6.2+

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Confirmed in recent master.

Changed in evergreen:
status: New → Confirmed
Ben Shum (bshum)
Changed in evergreen:
importance: Undecided → Medium
milestone: none → 2.4.0-alpha
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-alpha1 → 2.4.0-beta
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → none
Revision history for this message
Pasi Kallinen (paxed) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.5.0-alpha1
Revision history for this message
Remington Steed (rjs7) wrote :

Confirmed in 2.4. I tested Pasi's fix and it works as expected. Rebased to master, signed off, with only minor whitespace correction.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp888604_validate_closed_dates

Revision history for this message
Ben Shum (bshum) wrote :

Picked to master, rel_2_4, and rel_2_3. Thanks Pasi and Remington!

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.