Movies list is hard coded

Bug #894910 reported by Blade
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ares
Fix Committed
Wishlist
AlexB

Bug Description

The list of movies that get unlocked as a campaign progresses is hard coded to those used by WW in their campaign. This means that for custom campaigns that add missions, only those maps named the same as WW maps will cause movies to be unlocked. It would be nice for those that have implemented extended campaigns and/or used the third side campaign progression to be able to add custom movies to the list as missions are completed.

Revision history for this message
DCoder DCoder (dcoder1337) wrote :

I located the code handling this. I can rewrite it to be flexible in half an hour, if I see a reasonable suggestion for how to map this on the INI side.

Lowdown:
There are two global counters (A and S), tracking how many movies from the respective hardcoded list you've seen. Whenever map actions request a movie from that list to be played, those respective counters get updated. I need to throw out the tracking save/load code anyway, so let's rewrite the lists themselves as well and make them softcoded.

Revision history for this message
Blade (nadia-xy) wrote :

Is the list of movie names rather than the maps that need to be completed to unlock hard coded then? Perhaps an additional section in artmd.ini or rulesmd.ini to list the unlockable movies and then auto added entries in ra2md.ini to save if a given movie has actually been unlocked or not (rather than in save files as I assume is done now).

Revision history for this message
DCoder DCoder (dcoder1337) wrote :

Yes, it's a list of movies from [Movies], no extensions or anything. (And the two counters are "encrypted" in ra2md.ini right now, try [Network]NetID=ffc8,ffdf,ffc8 for some freebies.)

I'd say [UnlockableMovies] in artmd.ini with [UnlockedMovies] in ra2md.ini then.

Revision history for this message
Blade (nadia-xy) wrote :

Sounds good to me.

Revision history for this message
Renegade (renegade) wrote :

Closing as suspended since feedback has been requested and there was no activity on the issue for more than four weeks.

Issue will be of lower priority if re-opened.

Revision history for this message
Blade (nadia-xy) wrote :

This had auto suspended. Although low priority, it would be nice if it got some loving at some point :)

Revision history for this message
DCoder DCoder (dcoder1337) wrote :

Retargeting for a nearer milestone - easy enough to fix once I stop being lazy :p

Revision history for this message
Bug Importer (bug-importer) wrote :

It would be also great to add an optional removal of the movies button ingame, if someone doesn't want the movies to be previewed at all because for example - it's a TC which doesn't have any. :)

Revision history for this message
Teleros (teleros) wrote :

"It would be also great to add an optional removal of the movies button ingame, if someone doesn't want the movies to be previewed at all because for example - it's a TC which doesn't have any. :) "

If you fancy doing that I'd perhaps leave that feature until it's perhaps possible to do a thorough modding of the normal UI that way. Moving buttons, hiding them, re-arranging stuff on loading screens perhaps...

Revision history for this message
AlexB (alexander-b) wrote :

Have a look at issue bug:996 to disable the Play Movies button.

AlexB (alexander-b)
Changed in ares:
assignee: nobody → AlexB (alexander-b)
milestone: outdated-0.3 → 0.e
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.