Veterancy Inside Opentopped Units

Code related to this issue has just been checked in!
Author: AlexB
Location: ft-veterancy, r695
Revision comment:
Fixed issue #346: Mind-controllers can get a percentage of experience their puppets gain.
Fixed issue #464: OpenToppeds' and Gunners' passengers can gain veterancy.
Fixed issue #970: Airstrike designators like Boris can gain experience from the airstrike.
Fixed issue #1014: OpenTopped vehicles can pass experience to its passengers even if trainable.
SVN: http://svn.renegadeprojects.com/Ares/695

Good.

not that it's incredibly important or anything, but did you really have to bump up this old dead issue just to say "good"?

Oops. Well, I didn't know that would bump it up. Sorry!

Hm, I just realized that this issue was called old and dead three months ago. In ten days, this issue is resolved for half a year without any testing. Because it is part of a larger veterancy scheme it blocks the whole branch from being merged into 0.2. If a tester could spare a second to look into this I would be very grateful.

Battle Fortress Tests:
Experience.PromotePassengers=yes
-Infantry inside (4 Snipers) slowly earn veterancy after making the BFort elite by picking off tons of Conscripts on my test map

Experience.PromotePassengers=yes and Experience.PassengerModifier=5
-Infantry inside (4 Snipers) make the BFort elite, than rapidly become elites themselves.

Experience.FromPassengers=no and Experience.PromotePassengers=yes
-Infantry inside (1 Tanya) never gains veterancy, nor does the BFort. Once the BFort is elite, Tanya herself becomes elite.

Experience.PromotePassengers=yes with Experience.FromPassengers=no and Experience.PassengerModifier=5
-Infantry inside (4 Snipers) do not give the BFort experience and never become elite. When the BFort is elite, they rapidly gain experience themselves.

Overall it seems functional.

IFV Tests:
Experience.PromotePassengers=yes
-Infantry unit inside (Sniper) works the IFV up to elite status, and then becomes elite himself.

One issue here- EVA does not announce "Unit Promoted" for the infantry inside of the IFV. Only when it is disembarked will you notice it got promoted.

To clarify, these are my testing conditions:
Blank map with 1 IFV, 2 Battle Forts, 5 GIs, 4 Snipers, 1 Tanya and 5 SEALs. The other side has about 350 Conscripts.

I have just tested this and I can confirm that this works. Veterancy is given to a unit inside IFV or Battlefortress after those unit reach their elite status and continue their kills.

Fun fact: infantry that gets experience inside IFV will only receive the upgrade when it exits the vehicle (just like occupiers) but infantry that receives experience while in Battle Fortress will receive level upgrades real-time. You will hear "Unit promoted" report for a unit that's inside the open-topped vehicle.

The late promotion event for the IFV is because of the game not updating infantry while garrisoned or being transported. The Battle Fortess however does update infantry and thus the promotion is effective immediately.
Is this something that should be changed or can this issue be closed?

That sounds like a small fluke that, from my memory, can be dealt with by copying the promotion-related code from ::Update()... make a new issue for that, and if you need more than a few hours to make it work, don't target 0.2 .

EDIT:
-----

Retested in 0.1.696

Works perfect.

Just an FYI, this feature has not been moved out of the ft-veterancy code branch. You won't find it in the main code.

Or in other words, you can't test a feature that doesn't exist, as is the case here with 0.1.886

Code related to this issue has just been checked in!
Author: AlexB
Location: ft-veterancy, r903
Commit contains DLL: Yes
Revision comment:
Fixed issue #1359: Give promotion to gunners immediately.

Related to issue #464.
SVN: http://svn.renegadeprojects.com/Ares/903

Let's go, testers! When issue bug:1359 is confirmed working, this issue can be closed, too. Then there's a good chance the veterancy additions will be in 0.2 :)

IFV problem fixed in 0.1.903

This can be closed.

Thanks, all!

Closed.