almost always, if a shell command fails, the dispatcher should stop

Dispatcher fail to detect lava-installation error.

http://validation.linaro.org/lava-server/scheduler/job/12687

root@master:~# [rc=0]: <LAVA_DISPATCHER>2012-02-17 09:02:48 PM DEBUG: sendline : chroot /mnt/testrootfs lava-test install build-gcc-181350
chroot /mnt/testrootfs lava-test install build-gcc-181350
<LAVA_DISPATCHER>2012-02-17 09:02:50 PM DEBUG: expect (2400): 'root@master:'
chroot /mnt/testrootfs lava-test install build-gcc-18135 0
LAVA: Downloading file from: u'http://people.linaro.org/~ams/gcc-svn-181350.tar.bz2'
LAVA: Running shell command: u'tar xf gcc-svn-181350.tar.bz2 --checkpoint=1000'
LAVA: (stderr) tar (child): lbzip2: Cannot exec: No such file or directory
LAVA: (stderr) tar (child): Error is not recoverable: exiting now
LAVA: (stderr) tar: Child returned status 2
LAVA: (stderr) tar: Error is not recoverable: exiting now
ERROR: Command 'tar xf gcc-svn-181350.tar.bz2 --checkpoint=1000' returned non-zero exit status 2
root@master:~# [rc=1]: <LAVA_DISPATCHER>2012-02-17 09:05:43 PM DEBUG: sendline : chroot /mnt/testrootfs rm -rf lava-test

Assuming that commands are executed in a shell, an individual command can be allowed to fail like this:

   command that might fail || true

so, if it fails it runs "true", so the command as a whole gives success.

Equally, it could be:

   command || echo "COMMAND FAILED"

The echo completes successfully, so the whole commands always reports success.

On Mon, 27 Feb 2012 11:22:26 -0000, Andrew Stubbs <email address hidden> wrote:
> Assuming that commands are executed in a shell, an individual command
> can be allowed to fail like this:
>
> command that might fail || true
>
> so, if it fails it runs "true", so the command as a whole gives success.
>
> Equally, it could be:
>
> command || echo "COMMAND FAILED"
>
> The echo completes successfully, so the whole commands always reports
> success.

Err. We all know that :-)