Close button on document background color window
Bug #901400 reported by
Codain
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Inkscape |
New
|
Undecided
|
Unassigned |
Bug Description
In Fedora, going to File > Document properties > Background color show a color notepad selector in a dialog whithout Close button. To close, I'm forced to do a right click and then close.
In Windows, same steps but here I have the close button.
Don't know on Mac OS.
Same bug with others UI::Widget:
I think we should have the close button on each OS, because we have a dialog.
I've looked at the code and have seen that in fact the dialog is just hiding itself instead of closing (and deleting).This is not incompatible with having a close button (and in Windows it works well).
To post a comment you must log in.
> Don't know on Mac OS.
The color selector dialog used e.g. for the page background and the grid colors does not have its own close button on Mac OS X (using GTK+/Quartz, or GTK+/X11). I never had any issues with that: the dialog can be closed with <esc>, and with the close button provided by the window manager (in the top bar of window decoration, which also displays the name of the dialog).
For me personally, this is a non-issue (I never missed a 'Close' button _inside_ this specific dialog, and I always have one provided by the window manager). If you add an explicit close button to the widget, will it also be displayed inside the Fill & Stroke dialog, or e.g. the (depricated) gradient editor dialog, or in extensions dialogs using the same widget to select a color? AFAIU this color selection notebook widget is used elsewhere - thus your proposal could possibly duplicate a close button which can optionally be displayed in (almost) all dialogs (see 'Inkscape Preferences > Windows > Miscellaneous > [ ] Show close button on dialogs')? :RegisteredColo rPicker widgets). I also was not aware that apparently the Windows port differs to such extents from the other platforms (beyond using native file dialogs) and can't recall having seen a screenshot of the mentioned dialog on Windows with the additional 'Close' button as part of the dialog (using a Gtk button)).
(Note: I'm not a developer and did not take a closer look at the code you refer to (UI::Widget:
On Fedora, do you use docked dialogs (default) or floating dialogs (which cannot -not even optionally- be docked)? This can be set in 'Inkscape Preferences > Windows > Dialog Behavior', as can . Or could it be that your window manager does not provide the close button for such types of dialogs?
Attached: screenshot of current trunk - Gtk+/Quartz to the left, Gtk+/X11 to the right.