Evergreen

Claims Returned count can be unintentionally overwritten

Bug #929172 reported by Jeff Godin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.4.0-alpha1

Bug Description

It is possible to overwrite a user's claims_returned_count value without warning in the staff client.

Observed on Evergreen 2.1:

1. Retrieve a patron with at least one open circ
2. Select Edit
3. Switch to Items Out
4. Mark an item Claimed Returned
5. Switch back to Edit, (optionally?) make an edit, such as to the user Alert Message
6. Save

No error about your Save potentially overwriting changes.

The user's Claims-returned Count will have the value that it previously had, before you marked the circ Claimed Returned above.

Teaching the database function action.circulation_claims_returned how to update last_xact_id might help.

Revision history for this message
Michael Peters (mrpeters) wrote :

This is confirmed with rel_2_2_beta2 and master.17b8f4a

tags: added: circulation claimsreturned
Changed in evergreen:
status: New → Incomplete
status: Incomplete → Confirmed
importance: Undecided → Medium
Jason Stephenson (jstephenson)
Changed in evergreen:
status: Confirmed → In Progress
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

"Teaching the database function action.circulation_claims_returned how to update last_xact_id might help."

Nah, that was too hard. I taught Circ.pm how to update the claims_returned_count manually:

    Kludge for LP 929172.

    When marking a copy claims returned, we manually update the patron's
    claims returned count, even though a database trigger apparently does
    this for us. The trigger doesn't update the patron's last_xact_id, but
    updating via the perl code does.

working/user/dyrcona/lp929172

Changed in evergreen:
status: In Progress → Confirmed
assignee: Jason Stephenson (jstephenson) → nobody
tags: added: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

The code to fix this and this bug is superseded by the branch for https://bugs.launchpad.net/bugs/1053643

I am therefore flagging this bug invalid and removing the pullrequest tag.

Changed in evergreen:
status: Confirmed → Won't Fix
status: Won't Fix → Invalid
tags: removed: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Actually, let's make this one fix committed since a fix did go in.

Changed in evergreen:
status: Invalid → Fix Committed
milestone: none → 2.4.0-alpha
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.