User is not warned when data filled in is too long. Field's size should impact its validity.

Hi,

This looks like an annoying bug indeed, but not a complete showstopper, as the workaround is very simple: enter a shorter value in the field (even if that may not be obvious to end-users based on the error). Therefore it seems to me that the bug cannot be considered Critical, but rather Medium or High.

Thanks!

PS: Please don't confirm or change the importance of your own bug reports. That would be like approving your own merge proposals. As a member of OpenERP Drivers, if you are unsure about the meaning of bug importance values, you really must read and understand our bug management guidelines in the documentation: http://doc.openerp.com/v6.0/contribute/11_bug_tracker.html#definition-of-a-bug

Using a database with all modules installed on runbot, I can't reproduce the error you are mentioning on the description. The behavior I see is that the value is trimmed at the limit silently, so the user may not notice that a part of the input was cut, but that's all. As limits are usually high enough for most uses, Medium seems like an appropriate importance.

Can't reproduce the error neither.

Maybe the client should mark fields as invalid when data filled in is greater than defined size.

Thanks Olivier, yes the value is trimmed silently, users needs to feel the limit in fields.

Regards,

Hello Fabien, so you can reproduce it ?.

Client must limit the input, its important think in preventive way not in corrective way.

Regards,

On 03/28/2012 02:20 PM, Fabien Meghazi (OpenERP) wrote:
> Maybe the client should mark fields as invalid when data filled in is
> greater than defined size.

Yes, it must do that, or explicitly prevent entering more characters in an
input/textarea than allowed by the corresponding size attribute, as was the
case in previous OpenERP clients (and in the GTK).
Watch out that there are cases where a widget=text is used on a fields.char and
other cases where widget=char is used on a fields.text. So it's better to make
the support generic in both widgets, independently of the actual field type.

The HTML 5 maxlength attribute seems to fit the bill, although I didn't check
current browser support.

This is important:

- when a module wants to limit the size of an field for a functional reason,
the client must verify it. This has always worked on all OpenERP clients

- silently trimming the input is worse than raising an error because the
end-user may lose valuable data without knowing it (the server side silently
slices the values before saving them in the database as a final sanity-check).
Such values must be caught client-side as part of the field validation.

Hello,

This has been fixed in lp:~openerp-dev/openerp-web/6.1-opw-573377-msh.

Thanks.

Fixed in Revision:
2306 revid:<email address hidden>