Acq: Refactor General Search for more smarts and speed

Bug #983195 reported by Lebbeous Fogle-Weekley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.0
Fix Released
Undecided
Unassigned
2.1
Fix Released
Undecided
Unassigned
2.2
Fix Released
Undecided
Unassigned

Bug Description

For Evergreen 2.0+ (eventually); 2.2+ (now)

A previous refactor of Acq general search (bug #927685) had the goal of returning a fuller result set when you search for objects based on the properties of a related invoice than what you, or for invoices based on the properties of related objects.

That implementation led to serious performance, which Ben Shum reported, and which this aims to address:

This branch is for 2.2 and master:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/acq-unified-search-refactor

For 2.1 and before, the previous refactor (bug #927685) still hasn't been backported, although it was meant to be. I will close that bug and merge the work from that with this new work. The result will go into branches specifically for 2.1 and 2.0 and I will link to them on *this* bug.

Tags: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

I've pushed for master and rel_2_2.

Here are branches for backporting into rel_2_1 and rel_2_0, respectively (incorporating the previously neglected work from bug #927685 as mentioned above). Need sign-off.

Thanks all!

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/acq-unified-search-refactor-rel_2_1

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/acq-unified-search-refactor-rel_2_0

Bill Erickson (berick)
Changed in evergreen:
status: Confirmed → Fix Committed
Revision history for this message
Dan Scott (denials) wrote :

Pushed to rel_2_1 (and updated the version_upgrade script for 2.1.1-2.1.2 in master, rel_2_2, and rel_2_1 to boot).

Thanks Lebbeous!

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.