merge subdirs
Bug #479705 reported by
Robert Collins
This bug affects 6 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Aaron Bentley | ||
bzr-builder |
Fix Released
|
High
|
Andrew Bennetts |
Bug Description
We need to be able to merge subdirs.
e.g. given trunk in bzr-git, packaging in lp:ubuntu/foo, we want;
merge packaging lp:ubuntu/foo/debian debian
to merge only the debian directory
Related branches
lp://qastaging/~spiv/bzr-builder/merge-subdirs-479705
- James Westby: Pending requested
-
Diff: 19 lines (+3/-3)1 file modified__init__.py (+3/-3)
On hold
for merging
into
lp://qastaging/~james-w/bzr-builder/trunk-old
- Andrew Bennetts (community): Disapprove
- James Westby: Needs Fixing
-
Diff: 2784 lines (+1496/-600)10 files modifiedTODO (+0/-3)
__init__.py (+33/-377)
cmds.py (+492/-0)
ppa.py (+124/-0)
recipe.py (+421/-150)
setup.py (+13/-12)
tests/__init__.py (+4/-3)
tests/test_blackbox.py (+62/-16)
tests/test_ppa.py (+28/-0)
tests/test_recipe.py (+319/-39)
lp://qastaging/~abentley/launchpad/allow-0.3
Rejected
for merging
into
lp://qastaging/launchpad
- Aaron Bentley (community): Disapprove
- Paul Hummer (community): Approve
-
Diff: 205 lines (+26/-20)5 files modifiedlib/lp/code/browser/tests/test_sourcepackagerecipe.py (+5/-5)
lib/lp/code/interfaces/sourcepackagerecipe.py (+1/-1)
lib/lp/code/model/sourcepackagerecipedata.py (+2/-2)
lib/lp/code/model/tests/test_recipebuilder.py (+2/-2)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+16/-10)
lp://qastaging/~abentley/launchpad/allow-0.3-2
- Tim Penhey (community): Approve
-
Diff: 322 lines (+39/-37)6 files modifiedlib/lp/code/browser/tests/test_sourcepackagerecipe.py (+6/-6)
lib/lp/code/interfaces/sourcepackagerecipe.py (+3/-3)
lib/lp/code/model/sourcepackagerecipedata.py (+1/-1)
lib/lp/code/model/tests/test_recipebuilder.py (+11/-7)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+18/-16)
utilities/sourcedeps.conf (+0/-4)
Changed in bzr-builder: | |
importance: | Undecided → High |
Changed in bzr-builder: | |
assignee: | nobody → Andrew Bennetts (spiv) |
Changed in launchpad-code: | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in launchpad-code: | |
status: | Triaged → In Progress |
Changed in launchpad-code: | |
assignee: | nobody → Aaron Bentley (abentley) |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
With some help from Robert, I've written a patch to do this. Because merge lines already have an optional revspec field, and it's hard to distinguish subdir names from revspecs, the optional subpath comes after the revspec. i.e. to merge a debian dir of tip, you need a line like:
merge packaging lp:ubuntu/foo/debian -1 debian
It's a bit hackish. Suggestions for improvements are welcome.