wishlist: show list of modified files for non-merge commits too

Bug #1189292 reported by Glenn Morris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bzr email commit hook
New
Undecided
Unassigned

Bug Description

Hi,

It would be nice if bzr-email would show the list of modified files, like bzr log --verbose does.
Currently emailer.py only does this for _merge_ commits, not for simple commits. I assume this
is caused by the following section:

        if len(self.revision.parent_ids) <= 1:
            # This is not a merge, so we can special case the display of one
            # revision, and not have to encur the show_log overhead.
            lr = log.LogRevision(self.revision, self.revno, 0, None)
            lf.log_revision(lr)
        else:
            # let the show_log code figure out what revisions need to be
            # displayed, as this is a merge
            log.show_log(self.branch,
                         lf,
                         start_revision=rev1,
                         end_revision=rev2,
                         verbose=True
                         )

The else branch passes "Verbose=True" to show_log, but the if branch doesn't do anything similar.

Revision history for this message
Glenn Morris (rgm+lp) wrote :

I suppose I can simply hack it locally so that the else branch that calls show_log is always used.
The comment in the code suggests that is inefficient, so if there's a better solution, please let me know...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.