System Log viewer fails if .bzr.log path contains spaces: WindowsError 123
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar Explorer |
Fix Released
|
High
|
André Bachmann | ||
Bug Description
Bzr-Explorer v1.0.1 (Marco Polo) installed with bzr-2.1.
Bazaar => Explore => System Log fails with
"bzr: ERROR:[Error 123] The filename, directory name, or volume label syntax is incorrect: u"'C:\\Documents and Settings\\David\\My Documents\
This is apparently a converse of the fix released for #391334. If I back out the quoting introduced at r466 Qviewer finds the log file and displays it correctly.
With r466 in place, as released, .bzr.log says -
"0.125 bazaar version: 2.1.0
0.125 bzr arguments: [u'qviewer', u'"C:\\Documents and Settings\\David\\My Documents\
0.156 looking for plugins in C:/Documents and Settings/
0.156 looking for plugins in C:/Added Program Files/Bazaar/
0.469 encoding stdout as sys.stdout encoding 'cp850'
0.766 encoding stdout as sys.stdout encoding 'cp850'
0.953 None"
With the r466 quoting removed, 'System Log' displays .bzr.log and says -
"0.125 bazaar version: 2.1.0
0.125 bzr arguments: [u'qviewer', u'C:\\Documents and Settings\\David\\My Documents\
0.156 looking for plugins in C:/Documents and Settings/
0.156 looking for plugins in C:/Added Program Files/Bazaar/
0.469 encoding stdout as sys.stdout encoding 'cp850'
0.734 encoding stdout as sys.stdout encoding 'cp850' "
Giving the 'broken' argument to qviewer on the windows command line succeeds -
>bzr qviewer "C:\\Documents and Settings\\David\\My Documents\
Related to the fine detail of unicode support across different OSes perhaps?
(As an aside, it would be an aid to bug-reporting if the text in Error dialog boxes could be selected by a standard 'copy' operation.)
Related branches
- Martin Packman (community): Approve
-
Diff: 39 lines (+5/-6)2 files modifiedNEWS (+3/-0)
lib/app_suite.py (+2/-6)
| Irongut (irongut) wrote | #1 |
| Alexander Belchenko (bialix) wrote | #2 |
| Irongut (irongut) wrote RE: [Bug 534891] Re: System Log viewer fails (Marco Polo on WinXP) | #3 |
| Alexander Belchenko (bialix) wrote Re: System Log viewer fails (Marco Polo on WinXP) | #4 |
| Changed in bzr-explorer: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| Joseph Price (pricechild) wrote | #5 |
| David Roberts (smartgpx) wrote | #6 |
| tags: | added: easy quoting-paths |
| summary: |
- System Log viewer fails (Marco Polo on WinXP) + System Log viewer fails if .bzr.log path contains spaces |
| summary: |
- System Log viewer fails if .bzr.log path contains spaces + System Log viewer fails if .bzr.log path contains spaces: WindowsError + 123 |
| André Bachmann (andrebachmann-dd) wrote | #7 |
| Changed in bzr-explorer: | |
| assignee: | nobody → André Bachmann (andrebachmann-dd) |
| status: | Confirmed → In Progress |
| Changed in bzr-explorer: | |
| milestone: | none → 1.3.1 |
| status: | In Progress → Fix Released |
Just tested this on XP, 2003 R2 64-bit and 7. Strangely System Log works for me on 7 but I see the same error on XP and 2003 R2 64-bit.
All were identical fresh installs of bzr 2.1.0-1 with the only change from the default install being I don't install bzr-svn.