import failure in plugin-info during selftest
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
Critical
|
John A Meinel | ||
| Bazaar PQM Plugin |
Invalid
|
Undecided
|
Unassigned | ||
| bzr plugin info |
Invalid
|
Undecided
|
Unassigned | ||
Bug Description
This is with trunk revno 5399
[601749-
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/storage/
return the_callable(*args, **kwargs)
File "/storage/
ret = run(*run_argv)
File "/storage/
return self.run(
File "/storage/
return self._operation
File "/storage/
self.cleanups, self.func, *args, **kwargs)
File "/storage/
result = func(*args, **kwargs)
File "/storage/
result = tests.selftest(
File "/storage/
suite = test_suite(
File "/storage/
plugin_suite = plugin.test_suite()
File "/storage/
return self.module.
File "/home/
from bzrlib.tests import TestLoader
ImportError: cannot import name TestLoader
Related branches
- Jelmer Vernooij (community): Approve
-
Diff: 52 lines (+21/-0)3 files modifiedNEWS (+4/-0)
bzrlib/tests/__init__.py (+4/-0)
bzrlib/tests/test_selftest.py (+13/-0)
| John A Meinel (jameinel) wrote | #1 |
| John A Meinel (jameinel) wrote | #2 |
| Changed in bzr: | |
| assignee: | nobody → John A Meinel (jameinel) |
| importance: | Undecided → Critical |
| status: | New → In Progress |
| Changed in bzr: | |
| milestone: | none → 2.3b1 |
| status: | In Progress → Fix Released |
| John A Meinel (jameinel) wrote | #3 |
| Changed in bzr-pqm: | |
| status: | New → Invalid |
| Changed in bzr-plugin-info: | |
| status: | New → Invalid |
I ran into this the other day in bzr-pqm as well.
We now use "TestUtil.
However, given that we have 'TestCase' explicitly exposed in tests, I think it is reasonable to have TestLoader also exposed. While switching the plugins to use the 'def load_tests(... loader ...)' syntax will give them a loader so they don't have to provide their own, it still seems reasonable to keep the base test infrastructure classes available in 'bzrlib.tests.*'.
Though that is certainly just my opinion.