DELETE operations do not handle all success return codes properly
Bug #1204734 reported by
Reagan Sanders
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar WebDAV plugin |
Fix Released
|
Undecided
|
Reagan Sanders |
Bug Description
Per RFC 2616 S9.7, 200, 202, and 204 are all valid success responses for a delete operation. For this use case, 202 probably isn't a very good sign (it means the deletion is queued but hasn't taken place yet), but it probably shouldn't be fatal as it currently is. 200 definitely shouldn't produce any error output, as it does currently (a squashed curl_http_error erroneously stating that the delete failed), since it's equivalent to a 204 except for indicting the presence of an entity in the response.
Related branches
lp://qastaging/~vexo/bzr-webdav/bzr-webdav
- Richard Wilbur: Approve
- Vincent Ladeuil: Needs Fixing
- Reagan Sanders (community): Needs Resubmitting
-
Diff: 117 lines (+35/-8)2 files modifiedtests/dav_server.py (+28/-2)
webdav.py (+7/-6)
Changed in bzr-webdav: | |
assignee: | nobody → Reagan Sanders (vexofp) |
status: | New → In Progress |
Changed in bzr-webdav: | |
status: | In Progress → Fix Released |
To post a comment you must log in.