testament in binary
Bug #1010339 reported by
John A Meinel
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
In Progress
|
Low
|
John A Meinel | ||
Bug Description
'bzr testament' currently writes directly to stdout rather than using self.outf. That got around needing to use encoding_type = 'exact' to avoid getting double-encoding errors. However, it also doesn't set O_BINARY on sys.stdout which means that on windows it mangles LF to CRLF.
Basically, we should have the property that:
bzr testament --long | sha1sum
matches
bzr testament
It is a fairly straightforward fix.
Related branches
lp://qastaging/~jameinel/bzr/2.4-testament-binary-1010339
- Vincent Ladeuil: Needs Information
- Alexander Belchenko: Approve
-
Diff: 91 lines (+24/-2)4 files modifiedbzrlib/btree_index.py (+6/-0)
bzrlib/builtins.py (+3/-2)
bzrlib/tests/blackbox/test_testament.py (+11/-0)
doc/en/release-notes/bzr-2.4.txt (+4/-0)
| Changed in bzr: | |
| assignee: | nobody → John A Meinel (jameinel) |
| importance: | Undecided → Low |
| status: | New → In Progress |
To post a comment you must log in.
