bzr diff requires lock

Bug #176905 reported by Aidan Delaney
2
Affects Status Importance Assigned to Milestone
Bazaar
New
Undecided
Unassigned

Bug Description

bzr diff requires a dirstate lock in order to proceed. Given that "diff" does not modify the codebase I don't see why it must acquire a lock. An attempt to grab a lock foils the following usecase: When writing the changelog entry for a revision I want to review the diff. However I can't run "bzr diff" during my "bzr ci" as checkin acquires the lock.

(I'm probably the words only fan of "tla make-log", based on the above use-case.)

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 176905] bzr diff requires lock

Aidan Delaney пишет:
> Public bug reported:
>
> bzr diff requires a dirstate lock in order to proceed. Given that
> "diff" does not modify the codebase I don't see why it must acquire a
> lock. An attempt to grab a lock foils the following usecase: When
> writing the changelog entry for a revision I want to review the diff.
> However I can't run "bzr diff" during my "bzr ci" as checkin acquires
> the lock.

It's a known issue.
Try this:

bzr ci --show-diff

Revision history for this message
John A Meinel (jameinel) wrote :

It is actually taking out a "shared" lock, but mostly to make sure that no other process is trying to take out an exclusive lock. But commit is about to modify the file, and that would cause 'diff' to read invalid data.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.