bzr patch --strip crash on non integer argument
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned | ||
Breezy |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
using --strip with non relevant argument such as a character crash
here the stacktrace:
bzr patch ~/Desktop/
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/usr/lib/
return run_bzr(argv)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
commands.
File "/usr/lib/
args, opts = parse_args(self, argv, alias_argv)
File "/usr/lib/
options, args = parser.
File "/usr/lib/
stop = self._process_
File "/usr/lib/
self.
File "/usr/lib/
option.
File "/usr/lib/
self.action, self.dest, opt, value, values, parser)
File "/usr/lib/
self.
File "/usr/lib/
v = self.type(value)
ValueError: invalid literal for int() with base 10: 'a'
bzr 1.5 on python 2.5.2 (linux2)
arguments: ['/usr/bin/bzr', 'patch', '/home/
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
avahi /home/visi/
bisect /home/visi/
bzrtools /usr/lib/
dbus /usr/lib/
gtk /usr/lib/
launchpad /usr/lib/
svn /home/visi/
upload /home/visi/
*** Bazaar has encountered an internal error.
Please report a bug at https:/
including this traceback, and a description of what you
were doing when the error occurred.
Related branches
- Martin Packman: Approve
-
Diff: 57 lines (+17/-1)4 files modifiedbreezy/option.py (+5/-1)
breezy/tests/blackbox/test_patch.py (+6/-0)
breezy/tests/test_options.py (+2/-0)
doc/en/release-notes/brz-3.1.txt (+4/-0)
affects: | bzrtools → bzr |
Changed in bzr: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
tags: | added: check-for-breezy |
tags: | removed: check-for-breezy |
Changed in brz: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Jelmer Vernooij (jelmer) |
milestone: | none → 3.1.0 |
Changed in brz: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |