Confusing error message if ssh login fails while using lp url

Hi,

This would be useful if http will work.

I think this would become part of the suggested overhaul of
transports, where the caller indicates whether they are going to
want to write to the transport and the provider acts appropriately.

Although, I'm not sure that there is any provision for fallback in
the current codebase, and so this might be quite a bit of work
on top of the above.

Thanks,

James

This is more than Low importance I think. Judging from IRC it happens to new users quite regularly, and it's a pretty unfortunate first impression of bzr.

Part of the problem is that the "Permission denied (publickey)." message, which is probably the most important part of the output, is somewhat buried by the very verbose error that comes after it. And the advice to try "-Dhpss" is a red herring most of the time.

Ideally, bzr should notice when the SSH connection failed to establish, and report an error more like:

$ bzr branch lp:foo
Permission denied (publickey).
bzr: ERROR: Failed to establish SSH connection to <email address hidden>.

I'm not sure how easy that is to achieve, but it would be a large improvement.