No locking when updating files in ~/.bazaar
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Vincent Ladeuil | ||
Bazaar Subversion Plugin |
Fix Released
|
High
|
Vincent Ladeuil | ||
Launchpad itself |
Fix Released
|
High
|
Jelmer Vernooij | ||
bzr (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Lucid |
Fix Released
|
Undecided
|
Unassigned | ||
Maverick |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
exarkun@boson:/tmp$ svnadmin create foo
exarkun@boson:/tmp$ bzr svn-import --incremental -v /tmp/foo /tmp/foo-bzr
Initialising Subversion metadata cache in /home/exarkun/
Using repository layout: root
Use 'bzr checkout' to create a working tree in the newly created branches.
exarkun@boson:/tmp$ bzr svn-import --incremental -v /tmp/foo /tmp/foo-bzr
Using repository layout: root
Use 'bzr checkout' to create a working tree in the newly created branches.
exarkun@boson:/tmp$ bzr svn-import --incremental -v /tmp/foo /tmp/foo-bzr
Using repository layout: root
Use 'bzr checkout' to create a working tree in the newly created branches.
exarkun@boson:/tmp$ ls foo-bzr/
exarkun@boson:/tmp$ bzr svn-import --incremental -v /tmp/foo /tmp/foo-bzr &bzr svn-import --incremental -v /tmp/foo /tmp/foo-bzr &bzr svn-import --incremental -v /tmp/foo /tmp/foo-bzr
[1] 19190
[2] 19191
Using repository layout: root
Using repository layout: root
bzr: ERROR: Error(s) parsing config file /home/exarkun/
Invalid line at line "3".
Duplicate section name at line 5.
Duplicate keyword name at line 6.
Use 'bzr checkout' to create a working tree in the newly created branches.
Use 'bzr checkout' to create a working tree in the newly created branches.
[1]- Exit 3 bzr svn-import --incremental -v /tmp/foo /tmp/foo-bzr
[2]+ Done bzr svn-import --incremental -v /tmp/foo /tmp/foo-bzr
exarkun@boson:/tmp$ cat /home/exarkun/
[261e6e09-
locations = file:///tmp/foo
istedmatrix.
guessed-layout = trunk0
[261e6e09-
Related branches
- Robert Collins (community): Needs Fixing
-
Diff: 893 lines (+410/-101) (has conflicts)6 files modifiedNEWS (+15/-0)
bzrlib/builtins.py (+27/-14)
bzrlib/config.py (+130/-29)
bzrlib/tests/blackbox/test_break_lock.py (+44/-20)
bzrlib/tests/test_commands.py (+1/-1)
bzrlib/tests/test_config.py (+193/-37)
- John A Meinel: Needs Fixing
-
Diff: 52 lines (+13/-4)2 files modifiedNEWS (+4/-0)
bzrlib/config.py (+9/-4)
- bzr-svn developers: Pending requested
-
Diff: 42 lines (+10/-6)2 files modifiedNEWS (+3/-0)
config.py (+7/-6)
- Tim Penhey (community): Approve
- Launchpad code reviewers: Pending (code) requested
-
Diff: 24 lines (+4/-4)1 file modifiedutilities/sourcedeps.conf (+4/-4)
- John A Meinel: Approve
-
Diff: 864 lines (+375/-67)8 files modifiedNEWS (+14/-6)
bzrlib/builtins.py (+27/-14)
bzrlib/config.py (+105/-24)
bzrlib/plugins/launchpad/test_account.py (+1/-1)
bzrlib/tests/blackbox/test_break_lock.py (+24/-1)
bzrlib/tests/test_commands.py (+1/-1)
bzrlib/tests/test_config.py (+202/-19)
bzrlib/tests/test_smtp_connection.py (+1/-1)
tags: | added: code-import |
tags: | added: canonical-losa-lp |
summary: |
- bzr svn-import fails when invoked concurrently + bzrlib.config.IniBasedConfig doesn't lock |
summary: |
- LocationsConfig doesn't lock around bzrlib.config.IniBasedConfig + No locking when updating files in ~/.bazaar |
tags: | added: udd |
Changed in bzr: | |
milestone: | none → 2.2.0 |
Changed in bzr: | |
assignee: | nobody → Vincent Ladeuil (vila) |
status: | Confirmed → In Progress |
Changed in bzr-svn: | |
status: | Triaged → In Progress |
assignee: | nobody → Vincent Ladeuil (vila) |
Changed in bzr-svn: | |
status: | In Progress → Fix Committed |
milestone: | none → 1.0.3 |
status: | Fix Committed → In Progress |
Changed in bzr-svn: | |
status: | In Progress → Fix Committed |
Changed in bzr-svn: | |
status: | Fix Committed → Fix Released |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
tags: | added: sru |
Changed in bzr (Ubuntu): | |
status: | New → Fix Released |
Changed in bzr (Ubuntu Maverick): | |
status: | Triaged → Confirmed |
tags: | added: config |
tags: | added: affects-twisted |
I'm not sure what the best way is to fix this. I guess we'll have to start locking ~/.bazaar/ subversion. conf.