disconnecting the sftp transport hangs

Bug #677305 reported by Michael Hudson-Doyle
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Unassigned
Launchpad itself
Fix Released
High
Aaron Bentley

Bug Description

Bzrlib hangs when a connected sftp transport is deleted:

>>> from bzrlib.transport import get_transport
>>> t = get_transport('sftp://localhost/')
>>> t.list_dir('.')
['initrd.img', 'lost%2Bfound', 'sys', 'media', 'lib', 'cdrom', 'opt', 'home', 'vmlinuz.old', 'var', 'initrd', 'selinux', 'vmlinuz', 'mnt', 'etc', 'lib32', 'srv', 'dev', 'proc', 'usr', 'nonexistent', 'bin', 'boot', 'root', 'tmp', 'lib64', 'initrd.img.old', 'sbin']
>>> del t
^CException KeyboardInterrupt: KeyboardInterrupt() in <function terminate at 0x26f7050> ignored

Seems present in 2.2.1 through trunk r5544.

Tags: lp-code qa-ok

Related branches

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This made all code imports fail in Launchpad. Reverting to 2.2.0 got them going again.

Revision history for this message
Max Bowsher (maxb) wrote :

There's a strong likelyhood that this is a dup of bug 659590.... in which case I've already had a fix landed on lp:bzr/2.2 :-)

Revision history for this message
Vincent Ladeuil (vila) wrote :

Can you confirm that maxb's fix addresses the issue ?

It is worth releasing 2.2.2 then ?

Changed in bzr:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Yes, maxb's branch does seem to fix the issue for Launchpad. You might want to land it on trunk :-)

Aaron Bentley (abentley)
Changed in launchpad-code:
importance: Undecided → High
status: New → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
Changed in launchpad-code:
assignee: nobody → Aaron Bentley (abentley)
milestone: none → 10.12
tags: added: qa-needstesting
Changed in launchpad-code:
status: In Progress → Fix Committed
Revision history for this message
Robert Collins (lifeless) wrote :

As this is a rollback, its known-good.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Max Bowsher (maxb) wrote :

Fixed in bzr 2.2.2, tracked under bug 659590

Changed in bzr:
status: Confirmed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.