Lazy hooks not properly saved and restored in selftest

Bug #785054 reported by Martin Packman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
In Progress
Medium
Martin Packman

Bug Description

Lazy hooks registered for testcases are not unregistered after the test has been run. This keeps the cases alive and leaves bzrlib in an unclean state when selftest finishes.

I discovered this when merging bzr.dev to <lp:~gz/bzr/cleanup_testcases_by_collection_613247> and finding every testcase was being kept alive past its run again.

Tags: selftest
Martin Packman (gz)
Changed in bzr:
assignee: nobody → Martin [gz] (gz)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

is this still the case?

Revision history for this message
Martin Packman (gz) wrote :

The hooks clean code in selftest is still weird and probably not completely isolated, but the immediate symptom of immortal tests has been dealt with seperately by changing how the backup dicts are handled.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.