fails to commit if commiter name's contains non-ascii characters
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Critical
|
Vincent Ladeuil | ||
bzr (Debian) |
Fix Released
|
Unknown
|
|||
bzr (Ubuntu) |
Fix Released
|
High
|
Jelmer Vernooij |
Bug Description
Reported in Debian bug 630913 (regression in beta4):
$ bzr commit
Committing to: bzr+ssh://<email address hidden>
modified dh_python2
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/usr/lib/
return the_callable(*args, **kwargs)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
return self._operation
File "/usr/lib/
self.cleanups, self.func, *args, **kwargs)
File "/usr/lib/
result = func(*args, **kwargs)
File "/usr/lib/
lossy=lossy)
File "/usr/lib/
result = unbound(self, *args, **kwargs)
File "/usr/lib/
result = WorkingTree.
File "/usr/lib/
result = unbound(self, *args, **kwargs)
File "/usr/lib/
*args, **kwargs)
File "/usr/lib/
lossy=lossy)
File "/usr/lib/
self.cleanups, self.func, self, *args, **kwargs)
File "/usr/lib/
result = func(*args, **kwargs)
File "/usr/lib/
message = message_
File "/usr/lib/
start_
File "/usr/lib/
if not _run_editor(
File "/usr/lib/
for candidate, candidate_source in _get_editor():
File "/usr/lib/
e = config.
File "/usr/lib/
for section in sections:
File "/usr/lib/
self.load()
File "/usr/lib/
self.
File "/usr/lib/
co_input = StringIO(
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc5 in position 52: ordinal not in range(128)
bzr 2.4b4 on python 2.6.7 (Linux-
arguments: ['/usr/bin/bzr', 'commit']
plugins: bash_completion
changelog_
explorer[
netrc_
weave_
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_GB.UTF-8'
*** Bazaar has encountered an internal error. This probably indicates a
bug in Bazaar. You can help us fix it by filing a bug report at
https:/
including this traceback and a description of the problem.
(Note that the name of the reporter was "Piotr Ożarowski", so he has non-utf8 characters in his configuration).
Related branches
- Jelmer Vernooij (community): Approve
-
Diff: 261 lines (+131/-16)4 files modifiedbzrlib/config.py (+21/-11)
bzrlib/errors.py (+9/-0)
bzrlib/tests/test_config.py (+97/-5)
doc/en/release-notes/bzr-2.4.txt (+4/-0)
tags: | added: patch |
Changed in bzr: | |
assignee: | nobody → Vincent Ladeuil (vila) |
Changed in bzr: | |
milestone: | none → 2.4b5 |
status: | Confirmed → Fix Released |
Changed in bzr (Debian): | |
status: | Unknown → Fix Released |
Changed in bzr (Ubuntu): | |
status: | Triaged → Fix Released |
assignee: | nobody → Jelmer Vernooij (jelmer) |
A bit more explanations about this bug: it has been introduced in lp:bzr revno 5945. This was 2011-05-31 and there was no report about it until we released 2.4b4 on debian sid.
It impacts anybody with a bazaar.conf containing some non-ascii chars but only when no BZR_EDITOR environment variable is set.
So the workaround is to set BZR_EDITOR to a valid editor.