test_source should fail on syntax errors
Bug #821838 reported by
Martin Packman
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Confirmed
|
Wishlist
|
Unassigned | ||
Bug Description
Currently test_source does not actually check that modules will compile without SyntaxError being thrown. It used to, but as an optimisation, only certain files matching a pattern are parsed.
This caught me out in <lp:~gz/bzr/trivial_cleanup_knownfailure> where I ran `bzr selftest -s bt.test_source` after doing a basic find and replace to check I'd not made any obvious mistakes. The tests passed, but one file did in fact have a syntax problem.
Revision history for this message
| Vincent Ladeuil (vila) wrote | #1 |
| Changed in bzr: | |
| importance: | Undecided → Wishlist |
| status: | New → Confirmed |
| tags: | added: check-for-breezy |
To post a comment you must log in.
This is unlikely to be widely needed. Still, it is useful (as demonstrated by the use case).
I wonder if it falls into the category of tests we want to run occasionally (as opposed to the ones we want PQM to run for example), in which case we may want to define specific test suites with well-defined targets (test run as root, install tests, dev-oriented tests, etc)