E-reader crashes on collection edit (adding comma);Auto-update -> Manual update not handled right

Changing the component for this bug.

 assignee cbhaley
 status triaged

This are actually 2 bugs.

One: going from automatic to manual is not handled right

Two: comma is not handled as collection separator

Extra info:

Books are not updated right.
When e.g. removing a collection from a book not in the library, the data is not really removed.
Calibre shows the no collections.
When the E-reader is disconnected, the collections are back again.
Worse, collections removed by the E-reader, are back again.

Testcase:

Add a tag to a book in calibre (book must not be on your E-reader). -> ADDEDTAG
Make shure your tags are added as collections
Connect your reader to calibre.
Add book to reader
disconnect reader
reader has a new collection: ADDEDTAG
remove book from Calibre
remove collection ADDEDTAG from E-reader
Connect E-reader to Calibre
Calibre shows the book on your reader INCLUDING the ADDEDTAG collection
Remove the ADDEDTAG collection from the book.
Calibre shows the book without the collection
Disconnect E-reader
Collection is again shown on E-reader

@kovid, the failure steps require a *50 reader (or possibly a T1) so that collections can be edited on the reader. I don't have one, so I have to give that part of this report back to you. I have fixed the "changing metadata management not working when the device is connected problem" by disabling the change while a device is connected.

@drmerry: I assume that you are using manual management in that last test case.

I'm closing this as fixed for the part of changing automatic->manual. Looking at the collections code, i don't see an easy way to add support for commas in collection names. You will just have to refrain from using commas in your collection names.

Fixed in branch lp:calibre. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased

I have a problem with one of your comments Kovid:

I'm closing this as fixed for the part of changing automatic->manual. Looking at the collections code, i don't see an easy way to add support for commas in collection names. You will just have to refrain from using commas in your collection names.

But I use the , to add an extra collection or separeate a collection in two collections right?

How do I add multiple collections to a book on the reader when I'm not allowed to add a , ? (Or, better described, the , is not seen as separator by calibre)

If you were actually adding multiple collections on the device, separated by a
comma, you would
end up with multiple collections without a comma in them. It's only if you
adda single collection with a comma in it that it wont work.

well, I wanted to separate an existing collection. But I think it does not work that way.