SSO client is not compatible with python3
Bug #1256365 reported by
Leo Arias
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical SSO provider |
Fix Released
|
Undecided
|
Leo Arias | ||
Bug Description
The ssoclient project is using iteritems on a dictionary, which in python3 was changed to just items()
Related branches
lp://qastaging/~elopio/canonical-identity-provider/fix1256365-python3
Merged
into
lp://qastaging/~canonical-isd-hackers/canonical-identity-provider/ssoclient
at
revision 17
- Ricardo Kirkner (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedssoclient/v2/client.py (+1/-1)
Revision history for this message
| Leo Arias (elopio) wrote | #1 |
| Changed in canonical-identity-provider: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-identity-provider: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
[09:45:55] <elopio> should I just change it to items(), or use six to make sure it will work the same in py2 and py3?
[09:53:08] <pindonga> elopio, I'd say, if you can make a single codebase work with py2 and py3 without external deps the better
[09:53:31] <pindonga> maybe the list is not that big and we can use .items() without harm
[09:54:51] <pindonga> I think it's safe to use .items()
[09:55:13] <elopio> pindonga: ok, I'll propose an MP with the change.