castellan

barbican_endpoint_type description doesn't match choices

Bug #1918704 reported by Eric Harney
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
castellan
Fix Released
Undecided
Takashi Kajinami

Bug Description

https://opendev.org/openstack/castellan/src/commit/35f1a20d517100c18ab53d2b5bf0afbf769a8f94/castellan/key_manager/barbican_key_manager.py#L75

The barbican_endpoint_type option has
  choices=['public', 'internal', 'admin']

but the description says "Allowed values are: public, private, and admin"

Eric Harney (eharney)
summary: - barbican_endpoint_type description doesn't match defaults
+ barbican_endpoint_type description doesn't match choices
Revision history for this message
Olaf Seibert (oseibert-sys11) wrote :

Cinder-api crashes / exits without logging anything useful if you use "[barbican]barbican_endpoint_type = private" which is really bad.

Takashi Kajinami (kajinamit)
Changed in castellan:
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to castellan (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/castellan/+/913695

Changed in castellan:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to castellan (master)

Reviewed: https://review.opendev.org/c/openstack/castellan/+/913695
Committed: https://opendev.org/openstack/castellan/commit/db91f2e8ab5fdba0c44bd2ec21e9dc32c44341dd
Submitter: "Zuul (22348)"
Branch: master

commit db91f2e8ab5fdba0c44bd2ec21e9dc32c44341dd
Author: Takashi Kajinami <email address hidden>
Date: Wed Mar 20 00:25:14 2024 +0900

    Drop wrong documented choices for barbican_endpoint_type

    The option never accepts "private". The choices are automatically
    documented by oslo-config-generator so we don't have to explicitly
    mention these in help string.

    Closes-Bug: #1918704
    Change-Id: I540f38d11b805a73fb310007f3c2848802ebb627

Changed in castellan:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/castellan 5.1.0

This issue was fixed in the openstack/castellan 5.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.