Ceilometer

There is a bug in V2 API AlarmThreahholdRule validate function

Bug #1280975 reported by Ildiko Vancsa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Ildiko Vancsa
Ceilometer 2014.1 "icehouse"
Havana
Fix Released
Medium
Ildiko Vancsa
Ceilometer 2013.2.3

Bug Description

The list of internal_keys is not defined correctly in the validate function of AlarmThresholdRule: timestamp_keys = ['timestamp', 'start', 'start_timestamp' 'end', 'end_timestamp']. The missing comma between the 'start_timestamp' and 'end' results in the following list: timestamp_keys = ['timestamp', 'start', 'start_timestampend', 'end_timestamp'].

The code snippet can be found here: https://github.com/openstack/ceilometer/blob/master/ceilometer/api/controllers/v2.py#L1308

Ildiko Vancsa (ildiko-vancsa)
Changed in ceilometer:
assignee: nobody → Ildiko Vancsa (ildiko-vancsa)
tags: added: havana-backport-potential
Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → icehouse-3
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/74795

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/73805
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=b1834e55fce08f1536c7d9392ae035b9583be8ed
Submitter: Jenkins
Branch: master

commit b1834e55fce08f1536c7d9392ae035b9583be8ed
Author: Ildiko Vancsa <email address hidden>
Date: Sat Feb 15 11:18:19 2014 +0100

    Refactor timestamp existence validation in V2 API

    There was a bug in AlarmThresholdRule in v2.py, the timestamp_keys
    were defined with a missing comma:
    ['timestamp', 'start', 'start_timestamp' 'end', 'end_timestamp'].

    The validation, if the timestamp field is used or not, was unclear
    in the current implementation. A new parameter, 'timestamp_is_valid',
    was added to the validation functions to show, if the timestamp is
    allowed to use or not in the validated query.

    Fixes bug 1280975

    Change-Id: I2aaef54354926f9afe3bb1d4fae8f8aa0ae600ab

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/75058

Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/havana)

Reviewed: https://review.openstack.org/75058
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=2c6a84f17dff2e0eb3970e0f89d8ea3e1d21cde5
Submitter: Jenkins
Branch: stable/havana

commit 2c6a84f17dff2e0eb3970e0f89d8ea3e1d21cde5
Author: Ildiko Vancsa <email address hidden>
Date: Sat Feb 15 11:18:19 2014 +0100

    Refactor timestamp existence validation in V2 API

    There was a bug in AlarmThresholdRule in v2.py, the timestamp_keys
    were defined with a missing comma:
    ['timestamp', 'start', 'start_timestamp' 'end', 'end_timestamp'].

    The validation, if the timestamp field is used or not, was unclear
    in the current implementation. A new parameter, 'timestamp_is_valid',
    was added to the validation functions to show, if the timestamp is
    allowed to use or not in the validated query.

    Fixes bug 1280975

    (cherry picked from commit b1834e55fce08f1536c7d9392ae035b9583be8ed)

    Change-Id: I2aaef54354926f9afe3bb1d4fae8f8aa0ae600ab

Alan Pevec (apevec)
tags: removed: havana-backport-potential
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.